Conversation
|
👋 Hello @asabri97, thank you for submitting a -✅ Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions. For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Good, focused fix aligning Android/iOS OBB payloads and ensuring Flutter exposes OBB polygons via polygon/obbPoints, with solid test coverage. Two robustness gaps remain: (1) bounding box computation can still output infinities when points is present but invalid, and (2) obbPoints parsing should filter to points that include both x and y to avoid partially-formed coordinates.
💬 Posted 2 inline comments
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review 2
Made with ❤️ by Ultralytics Actions
PR looks clean. The changes are consistent with the stated goal, and I didn’t find any new bugs or reliability issues in the modified lines.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Fixes Oriented Bounding Box (OBB) coordinate retrieval so Flutter can correctly expose
YOLOResult.obbPoints✅📊 Key Changes
classIndexto OBB result maps on Android (YOLOPlugin.kt) and iOS (YOLOInstanceManager.swift) for consistent metadatapolygonfield from OBBpoints, enablingYOLOResult.obbPointsextractionYOLOResultwithobbPoints, adds backward-compatible parsing (polygonorobbPoints), and includes polygon intoMap()0.1.47and documents the fix inCHANGELOG.mdtoMap()/fromMap()round-trip🎯 Purpose & Impact
classIndexhandling 🧩