Conversation
|
I have read the CLA Document and I sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
👋 Hello @paradoxsyn, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Looks clean overall. The new MethodChannel surface is wired consistently across Dart, Android (CameraX), and iOS (AVCaptureDevice), with reasonable null-safety and graceful fallbacks (e.g., returning false/null when unavailable). No clear bugs or failure cases introduced in the shown diff.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
@paradoxsyn please sign the CLA |
| /** | ||
| * Locks the exposure at the current level. | ||
| */ | ||
| fun lockExposure() { |
There was a problem hiding this comment.
Can we double check this method?
This approach isn't locking and the single path in setAutoFocusMode call cancelFocusAndMeterinng(), which resets metering back to default auto behavior. The method claims to lock but likely return to auto so the feature behaves opposite of its contract.
Adds opt-in greedy IoU tracker in Dart layer that assigns stable integer trackId to each detection across frames. Useful for avoiding re-scanning of mostly-stationary objects like cards. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
this is just a quick fix to add the flashlight. im using this personally figured I'd stick it here. I won't have time to check other submissions but this was quick so.
Best
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Adds cross-platform torch (flashlight) controls to the Flutter YOLO camera view via new MethodChannel APIs. 🔦
📊 Key Changes
toggleTorch,setTorchMode(enabled),isTorchAvailable, andisTorchEnabled(Android + iOS).YOLOViewusing CameraX (enableTorch,torchState,hasFlashUnit).YOLOViewviaAVCaptureDevicetorch configuration (lock/unlock + max torch level).lib/widgets/yolo_controller.dartwith basic error handling and null-safe query methods.🎯 Purpose & Impact