Skip to content

fix: publish on main#198

Merged
asabri97 merged 1 commit intomainfrom
fix-publishing-on-main
Nov 3, 2025
Merged

fix: publish on main#198
asabri97 merged 1 commit intomainfrom
fix-publishing-on-main

Conversation

@asabri97
Copy link
Contributor

@asabri97 asabri97 commented Oct 27, 2025

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Tightens the iOS app’s release workflow: releases now only cut from main on version bumps, while TestFlight builds are clearer and safer to trigger. 🚀

📊 Key Changes

  • Removes the manual release input; releases can’t be toggled via workflow_dispatch anymore.
  • Clarifies the source_branch input: used only to build; releases are created from main.
  • Updates descriptions for clearer intent (e.g., “Build and push to TestFlight”).
  • Release job condition tightened: runs only on push events to main and when a new version is detected.
  • TestFlight job condition refined: runs on pull requests, or on manual runs only if testflight is true.

🎯 Purpose & Impact

  • Prevents accidental releases from non-main branches or manual triggers ✅
  • Enforces a clean, predictable release policy tied to version bumps on main 🔒
  • Gives contributors a safe path to TestFlight builds via PRs or explicit manual opt-in 🧪
  • Reduces confusion in CI by removing ambiguous inputs and clarifying workflow behavior 🧭
  • Improves reliability and consistency of App Store/TestFlight delivery for users 📦

@asabri97 asabri97 temporarily deployed to Release - TestFlight October 27, 2025 18:22 — with GitHub Actions Inactive
@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops fixed Bug has been resolved labels Oct 27, 2025
@UltralyticsAssistant
Copy link
Member

👋 Hello @asabri97, thank you for submitting a ultralytics/yolo-ios-app 🚀 PR! To ensure a seamless integration of your work, please review the following checklist:

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/yolo-ios-app main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. This is an automated message — an engineer will follow up to assist. 🙏✨

Copy link
Member

@UltralyticsAssistant UltralyticsAssistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

Looks good to me. Changes tighten release triggers and clarify TestFlight usage without introducing issues.

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@asabri97 asabri97 merged commit 65146f4 into main Nov 3, 2025
8 checks passed
@asabri97 asabri97 deleted the fix-publishing-on-main branch November 3, 2025 06:49
@UltralyticsAssistant
Copy link
Member

🎉 Merged and marvelous! Thank you, @asabri97, for sharpening our iOS release workflow.

“Well done is better than well said.” — Benjamin Franklin
Your changes turn best practices into reality: releases now flow predictably from main on version bumps, TestFlight triggers are safer and clearer, and accidental releases are off the table. This is a big win for reliability and contributor confidence across our iOS pipeline. 🚀

Appreciate the craftsmanship and care here—thanks for making our delivery process stronger!
See details in the merged changes: PR #198 – Tighten iOS release/TestFlight workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops GitHub Devops or MLops fixed Bug has been resolved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants