Skip to content

Fix typo in print message in getModelInputSize#201

Merged
glenn-jocher merged 3 commits intoultralytics:mainfrom
cdeil:fix-input-size-print-typo
Oct 30, 2025
Merged

Fix typo in print message in getModelInputSize#201
glenn-jocher merged 3 commits intoultralytics:mainfrom
cdeil:fix-input-size-print-typo

Conversation

@cdeil
Copy link
Contributor

@cdeil cdeil commented Oct 29, 2025

I got this message with the default model and example HERE. Seems to work fine even though the message says model input size can't be determined. Weird.

Anyways, this PR just fixed the typo.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Fixes a typo in a log message within BasePredictor.getModelInputSize to improve clarity 🧹📝

📊 Key Changes

  • Corrected print message from "an not find input size" to "can not find input size" in Sources/YOLO/BasePredictor.swift

🎯 Purpose & Impact

  • Improves developer experience by providing clearer logging output
  • No functional or behavioral changes to the app
  • Aids debugging by making log intent unambiguous

@UltralyticsAssistant UltralyticsAssistant added the documentation Improvements or additions to documentation label Oct 29, 2025
@UltralyticsAssistant
Copy link
Member

👋 Hello @cdeil, thank you for submitting a ultralytics/yolo-ios-app 🚀 PR! This automated message will help ensure a smooth review. An Ultralytics engineer will assist you shortly.

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/yolo-ios-app main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

Copy link
Member

@UltralyticsAssistant UltralyticsAssistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

Please update the log message to use “cannot” so the sentence reads naturally.

💬 Posted 1 inline comment

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
Sources/YOLO/BasePredictor.swift 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

cdeil and others added 2 commits October 29, 2025 16:14
Co-authored-by: Ultralytics Assistant <135830346+UltralyticsAssistant@users.noreply.github.com>
Signed-off-by: Christoph Deil <Deil.Christoph@gmail.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher
Copy link
Member

@cdeil thank you for the PR!

@glenn-jocher glenn-jocher merged commit bee91a9 into ultralytics:main Oct 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants