Avoid double free of roi.file_path

[bart-kroon]

Changes

• Copy the file_path string after memcpy of cfg.

Issues

• Closes Double free of roi_file #427

Details

• Check if the same change is needed for optional_key and fastrd_learning_outdir_fn.

[Jovasa]

Thanks Bart,

Did you also mean to commit the src/kvazaar.pc.temp file? If not could you removed it? Additionally could you please squash all of these changes into a single commit?

Quickly looking, as you suggested, the same problem seems to exist for optional_key and fastrd_learning_outdir_fn, or at least I don't see any reason why it wouldn't.

- Joose

[bart-kroon]

Thanks Bart,

Did you also mean to commit the src/kvazaar.pc.temp file? If not could you removed it? Additionally could you please squash all of these changes into a single commit?

Quickly looking, as you suggested, the same problem seems to exist for optional_key and fastrd_learning_outdir_fn, or at least I don't see any reason why it wouldn't.

• Joose

Hi Joose,

This is the cleaned-up PR. I'll leave optional_key and fastrd_learning_outdir_fn to the team because I don't want to make an error with that.

Best regards,

Bart

[Jovasa]

Thanks!