feat: remove golangci-lint mode #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
feat/remove-golancgi-lint-mode
branch
from
2c1da3f to
b33cbe5
Compare
robinknaapen
requested changes
Dec 17, 2024
There was a problem hiding this comment.
The rest LGTM, love to see the improvement made in golangci-lint. Great effort, thanks @ldez
robinknaapen
approved these changes
Dec 17, 2024
elwint
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The golangci-lint will not be require anymore, because golangci-lint will be compatible with
SuggestedFix.Related to golangci/golangci-lint#5232