Add async pubkey cache and key fetch method #71
Conversation
uma/uma.py
Outdated
|
|
||
| async def _run_http_get_async(url: str) -> str: | ||
| async with ClientSession() as session: | ||
| async with session.get(url) as response: # pyre-ignore [16] |
There was a problem hiding this comment.
this is the pyre error
uma/uma.py:152:19 Undefined attribute [16]: `aiohttp.client.ClientSession` has no attribute `get`.
There was a problem hiding this comment.
I think we might need to pin to 3.10 on aiohttp due to pyre incompatibility aio-libs/aiohttp#8463
There was a problem hiding this comment.
that fixed it, thanks!
| return public_key | ||
|
|
||
|
|
||
| async def fetch_public_key_for_vasp_async( |
There was a problem hiding this comment.
Do we care about using the gen_* convention here like we do internally? I don't have a strong preference, but was curious if anyone else does.
There was a problem hiding this comment.
@yunyuyunyu do you have any thoughts?
from quick googling it doesn't seem like a common convention so I almost prefer not to, but also not a strong preference
There was a problem hiding this comment.
That's a good question. I actually don't see many external libraries using prefix gen for their async functions. Hmm, @vdurmont do you have a preference?
There was a problem hiding this comment.
I don't feel strongly for external stuff.
There was a problem hiding this comment.
thanks all -- going to leave as is then!
There was a problem hiding this comment.
Actually, I'd lean towards keeping our consistency and use gen_. I acknowledge it's not widely used in the outside world, but it doesn't hurt at all.
|
Force merging because the 3.8 test won't run anymore after this. |
No description provided.