Skip to content

Conversation

@PaiJi
Copy link

@PaiJi PaiJi commented Dec 23, 2025

No description provided.

@vercel
Copy link

vercel bot commented Dec 23, 2025

@PaiJi is attempting to deploy a commit to the umami-software Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 23, 2025

Greptile Summary

This PR updates the Simplified Chinese (zh-CN) translation files with significant improvements:

  • Added ~40 new translation entries for recently added UI labels (account, action, add-link, add-pixel, analysis, audience, behavior, channel, chart, criteria, documentation, download, environment, location, preferences, profiles, segments, support, traffic, etc.)
  • Translated previously English-only error messages to Chinese (bad-request, forbidden, not-found, unauthorized, server-error)
  • Localized common labels like label.email ("Email" → "邮箱"), label.online ("Online" → "在线"), and label.referral ("Referral" → "来源")

Issues found:

  • label.table is mistranslated as "平板" (tablet/flat panel) instead of "表格" (data table)
  • Three labels left in English: label.growth, label.save-cohort, label.save-segment

Confidence Score: 3/5

  • This PR is a localization update with one semantic translation error that could confuse users.
  • Score of 3 reflects that while this is a valuable localization contribution, the label.table mistranslation ("平板" instead of "表格") could cause confusion in the UI. The untranslated labels are minor style issues that don't affect functionality.
  • src/lang/zh-CN.json - contains the label.table mistranslation that should be corrected before merging.

Important Files Changed

Filename Overview
src/lang/zh-CN.json Added many new Chinese translations and localized previously untranslated labels. Contains a few issues: label.table mistranslated as "平板" (tablet) instead of "表格" (table), and some labels left untranslated (label.growth, label.save-cohort, label.save-segment).
public/intl/messages/zh-CN.json Compiled message format version of the translations. Same issues as source file: label.table mistranslated as "平板", and labels label.growth, label.save-cohort, label.save-segment left in English.

Sequence Diagram

sequenceDiagram
    participant User as User (zh-CN)
    participant UI as Umami UI
    participant i18n as i18n System
    participant Lang as zh-CN.json

    User->>UI: Access Umami in Chinese
    UI->>i18n: Request translations
    i18n->>Lang: Load zh-CN messages
    Lang-->>i18n: Return translated strings
    i18n-->>UI: Apply translations
    UI-->>User: Display localized interface
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (3)

  1. src/lang/zh-CN.json, line 267 (link)

    logic: label.table is translated as "平板" (tablet/flat panel), but this key likely refers to a data table, not a tablet device. The correct translation should be "表格".

  2. src/lang/zh-CN.json, line 241-242 (link)

    style: These labels are left in English. Consider translating them to Chinese for consistency:

    • "Save as cohort" → "保存为队列"
    • "Save as segment" → "保存为细分"
  3. src/lang/zh-CN.json, line 130 (link)

    style: label.growth is left in English. Consider translating to "增长" for consistency with other Chinese translations.

2 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

@mikecao mikecao changed the base branch from master to dev January 7, 2026 01:28
Copy link
Collaborator

@mikecao mikecao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@mikecao mikecao merged commit d8dcf05 into umami-software:dev Jan 7, 2026
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants