-
Notifications
You must be signed in to change notification settings - Fork 6.3k
chore(i18n): update zh-CN translation #3920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(i18n): update zh-CN translation #3920
Conversation
|
@PaiJi is attempting to deploy a commit to the umami-software Team on Vercel. A member of the Team first needs to authorize it. |
Greptile SummaryThis PR updates the Simplified Chinese (zh-CN) translation files with significant improvements:
Issues found:
Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User as User (zh-CN)
participant UI as Umami UI
participant i18n as i18n System
participant Lang as zh-CN.json
User->>UI: Access Umami in Chinese
UI->>i18n: Request translations
i18n->>Lang: Load zh-CN messages
Lang-->>i18n: Return translated strings
i18n-->>UI: Apply translations
UI-->>User: Display localized interface
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (3)
-
src/lang/zh-CN.json, line 267 (link)logic:
label.tableis translated as "平板" (tablet/flat panel), but this key likely refers to a data table, not a tablet device. The correct translation should be "表格". -
src/lang/zh-CN.json, line 241-242 (link)style: These labels are left in English. Consider translating them to Chinese for consistency:
- "Save as cohort" → "保存为队列"
- "Save as segment" → "保存为细分"
-
src/lang/zh-CN.json, line 130 (link)style:
label.growthis left in English. Consider translating to "增长" for consistency with other Chinese translations.
2 files reviewed, 3 comments
mikecao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you!
No description provided.