Fix double scrollbar in dropdown #3939
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes UI issue where the WebsiteSelect dropdown in the sidebar would show two scrollbars with a long list on shorter viewports.
Before/After

Likely fixes #3913 although I was unable to replicate the exact situation seen in the issue's screenshot. (their issue only has one non-scrollable scrollbar)
Cause
The Select dropdown wrapper in @umami/react-zen:/src/components/Select.module.css:25 is scrollable and capped at 42vh.
The inner list is also scrollable, so increasing the inner list height beyond the wrapper cap creates nested scroll containers.
Fix
The maximum height of the dropdown list is now set relative to the viewport.