Skip to content

Commit 048f8bc

Browse files
authored
Fixed userResource request to get all users. (#18105)
1 parent 7bcbc74 commit 048f8bc

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

src/Umbraco.Web.BackOffice/Controllers/UsersController.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ public ActionResult<string[]> PostClearAvatar(int id)
322322
/// <returns></returns>
323323
[OutgoingEditorModelEvent]
324324
[Authorize(Policy = AuthorizationPolicies.AdminUserEditsRequireAdmin)]
325-
public ActionResult<IEnumerable<UserDisplay?>> GetByIds([FromJsonPath] int[] ids)
325+
public ActionResult<IEnumerable<UserDisplay?>> GetByIds([FromQuery] int[] ids)
326326
{
327327
if (ids == null)
328328
{

src/Umbraco.Web.BackOffice/DependencyInjection/UmbracoBuilder.BackOfficeAuth.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,7 @@ private static void CreatePolicies(AuthorizationOptions options, string backOffi
202202
{
203203
policy.AuthenticationSchemes.Add(backOfficeAuthenticationScheme);
204204
policy.Requirements.Add(new AdminUsersRequirement());
205+
policy.Requirements.Add(new AdminUsersRequirement("ids"));
205206
policy.Requirements.Add(new AdminUsersRequirement("userIds"));
206207
});
207208

src/Umbraco.Web.UI.Client/src/common/resources/users.resource.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,12 +318,14 @@
318318
*/
319319
function getUsers(userIds) {
320320

321+
var idQuery = "";
322+
userIds.forEach(id => idQuery += `ids=${id}&`);
321323
return umbRequestHelper.resourcePromise(
322324
$http.get(
323325
umbRequestHelper.getApiUrl(
324326
"userApiBaseUrl",
325327
"GetByIds",
326-
{ ids: userIds })),
328+
idQuery)),
327329
"Failed to retrieve data for users " + userIds);
328330
}
329331

0 commit comments

Comments
 (0)