Skip to content

Commit ba58c63

Browse files
Don't add a blanket rule to allow synchronous IO, should not be necessary for the new management API (#17886)
* Don't add a blanket rule to allow synchronous IO, should not be necessary for the new management API * Add obsolete warning
1 parent 0957559 commit ba58c63

File tree

1 file changed

+1
-12
lines changed

1 file changed

+1
-12
lines changed

src/Umbraco.Web.Common/DependencyInjection/UmbracoBuilderExtensions.cs

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -326,20 +326,9 @@ public static IUmbracoBuilder AddHelpers(this IUmbracoBuilder builder)
326326
return builder;
327327
}
328328

329-
// TODO: Does this need to exist and/or be public?
329+
[Obsolete("This is not necessary any more. This will be removed in v17")]
330330
public static IUmbracoBuilder AddWebServer(this IUmbracoBuilder builder)
331331
{
332-
// TODO: We need to figure out why this is needed and fix those endpoints to not need them, we don't want to change global things
333-
// If using Kestrel: https://stackoverflow.com/a/55196057
334-
builder.Services.Configure<KestrelServerOptions>(options =>
335-
{
336-
options.AllowSynchronousIO = true;
337-
});
338-
builder.Services.Configure<IISServerOptions>(options =>
339-
{
340-
options.AllowSynchronousIO = true;
341-
});
342-
343332
return builder;
344333
}
345334

0 commit comments

Comments
 (0)