Skip to content

#19736 adjust drag placeholder for document picker #19737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

enkelmedia
Copy link
Contributor

This partially fixes this issue: #19736

Description

This PR fixes the drag-placeholder for document picker to align with the look and feel of the Block List and Block Grid.

Before:
umb-drag-before

After:
umb-drag-after

Copy link

github-actions bot commented Jul 15, 2025

Hi there @enkelmedia, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@georgebid
Copy link
Contributor

Hey @enkelmedia, this looks great! Thanks for the PR, someone on the core collaborators team will review this soon 😄

@enkelmedia
Copy link
Contributor Author

@georgebid Thanks a lot! :)

@JasonElkin
Copy link
Contributor

JasonElkin commented Aug 5, 2025

This looks good.

As the aim is to make this look more like the block list and block grid (and there are more editors that #19736 suggests should change too) I feel like the shared CSS for this should be abstracted so it can be shared and modified in one place - like we do with UmbTextStyles?

Let me ask some HQers and see what they say.

@JasonElkin JasonElkin self-assigned this Aug 5, 2025
@enkelmedia
Copy link
Contributor Author

I agree with having a "central" thing would be nice but most of the time there needs to be specific selectors etc. which is not really possible by including a shared style.

I did consider that but felt like it would work for 50% of the cases and that felt worse than having it duplicated.

But, any concrete ideas are more than welcome and I'd be happy to update the PR accordingly :)

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants