V15 QA updated failing acceptance tests on the nightly pipeline #19882
+12
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates failing acceptance tests to align with changes in the V15 nightly pipeline. The main purpose is to fix test assertions that were failing due to updated error messages and notification text in the Umbraco application.
Key changes include:
- Updated validation error messages for character limit exceeded scenarios
- Fixed notification text expectations from "saved" to "created"
- Added missing success notification checks in collection tests
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ContentWithTextstring.spec.ts | Updated character limit validation error message to match new format |
| ContentWithTextarea.spec.ts | Updated character limit validation error message to match new format |
| ContentWithMediaPicker.spec.ts | Changed expected notification text from "saved" to "created" |
| ContentWithCollections.spec.ts | Added success notification visibility checks after save operations |
| package.json | Updated @umbraco/playwright-testhelpers dependency version |
Files not reviewed (1)
- tests/Umbraco.Tests.AcceptanceTest/package-lock.json: Language not supported
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTextstring.spec.ts
Show resolved
Hide resolved
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTextarea.spec.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.