V16/feature/move last synced id to db #19884
Merged
+519
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolajlauridsen
requested changes
Aug 8, 2025
src/Umbraco.Core/Persistence/Repositories/ILastSyncedRepository.cs
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Sync/LastSyncedManagerTest.cs
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Sync/LastSyncedManagerTest.cs
Outdated
Show resolved
Hide resolved
nikolajlauridsen
requested changes
Aug 11, 2025
src/Umbraco.Core/Persistence/Repositories/ILastSyncedRepository.cs
Outdated
Show resolved
Hide resolved
|
Lets try again 😄 |
nikolajlauridsen
approved these changes
Aug 11, 2025
nikolajlauridsen
merged commit e30dc50
into
v16/feature/load-balancing-isolated-caches
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have created a DB Table for our LastSyncedId. Previously it was saved in a file, and a file manager would handle it. This file manager has been obsoleted and replaced by a repository and a manager to save it in the database.
Along with this I have extended the ID to include internal and external, where internal will be used in the future. All of this comes with complete unit tests for validating the get, create and pruning jobs.