-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix #19676 #19886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix #19676 #19886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue (#19676) related to content type loading and promise handling in the Umbraco CMS workspace context. The changes focus on improving the reliability of content type structure loading by ensuring all content types are properly loaded before resolving promises.
Key changes:
- Adds proper promise rejection handling in document workspace context
- Implements an
allSuccess
observable in repository details manager to track loading states - Introduces comprehensive content type loading validation with error handling
- Creates a new utility function
observationAsPromise
for converting observables to promises with conditions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
document-workspace.context.ts | Added TODO comments for promise rejection handling |
repository-details-manager.ts | Added allSuccess observable and reordered operations in addEntry method |
content-type-structure-manager.class.ts | Enhanced content type loading with validation, error handling, and debug logging |
observation-as-promise.function.ts | New utility function for converting observables to conditional promises |
index.ts | Exported the new observationAsPromise function |
...I.Client/src/packages/content/content-type/structure/content-type-structure-manager.class.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/libs/observable-api/utils/observation-as-promise.function.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/libs/observable-api/utils/observation-as-promise.function.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/libs/observable-api/utils/observation-as-promise.function.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Fixes #19676 by ensuring that Compositions are loaded before running the Property Preset logic.