Remove Client build and restore targets from CSPROJ in template

[warrenbuckley]

Removed targets for restoring and building Client files.

Details

As discussed part of the Umbraco Community Package team call 14th November to remove this

[Copilot]

Pull Request Overview

This PR removes MSBuild targets for automated frontend build processes from the Umbraco extension template project file. The change eliminates the automatic restoration and building of Client files during the C# project build, requiring developers to manually manage their frontend build pipeline.

• Removed RestoreClient target that automatically ran npm i for Client packages
• Removed BuildClient target that automatically executed npm run build and tracked build outputs

[AndyButland]

I'm sure this is valid @warrenbuckley, but please could you update the description to explain why you are proposing this change? "As discussed" isn't really enough, particularly if someone is looking back in future. Thanks.

[iOvergaard]

I was just about to write the same thing as @AndyButland. We will accept the change but need to be able look back on it and read why it was done.
Also I would like to ask you to target the release/17.0 branch directly so we get it in the proper release.

[bjarnef]

Isn't this used to run npm i + npm run build when building project/solution on local environment?

We can of course run these directly from terminal.

Furthermore we has this change based on "Open Source Umbraco Cloud" repository:
https://github.com/LottePitcher/open-source-umbraco-cloud/blob/develop/src/OpenSourceTest.MyExtension/OpenSourceTest.MyExtension.csproj

<!-- Restore and build Client files outside of Cloud environments -->
  <Target Name="RestoreClient" 
		  Inputs="Client\package.json;Client\package-lock.json" 
		  Outputs="Client\node_modules\.package-lock.json">
    <Message Importance="high" Text="Restoring Client NPM packages..." />
    <Exec Command="npm i" WorkingDirectory="Client" />
  </Target>

  <Target Name="BuildClient" 
		  BeforeTargets="AssignTargetPaths" 
		  DependsOnTargets="RestoreClient" 
		  Inputs="@(ClientAssetsInputs)" 
		  Outputs="$(IntermediateOutputPath)client.complete.txt" 
          Condition="!('$(UMBRACO__CLOUD__ISRUNNINGONCLOUD)' == 'true' OR '$(ENVIRONMENT__PROJECTID)' != '')">
    <Message Importance="high" Text="Executing Client NPM build script..." />
    <Exec Command="npm run build" WorkingDirectory="Client" />
    <ItemGroup>
      <_ClientAssetsBuildOutput Include="wwwroot\App_Plugins\**" />
    </ItemGroup>
    <WriteLinesToFile File="$(IntermediateOutputPath)client.complete.txt" Lines="@(_ClientAssetsBuildOutput)" Overwrite="true" />
  </Target>

where ignore on build, but run npm i (or npm ci) + npm run build as part of CI/CD pipeline.

[warrenbuckley]

@AndyButland & @iOvergaard I am going to close this PR & redo it as was rushed and done directly in the browser whilst on the call, so apologies for the quality.

[warrenbuckley]

New PR is over here 👉 #20839