Router: Destroy route component when disconnected (Fixes #21272)#21318
Merged
nielslyngsoe merged 5 commits intomainfrom Jan 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #21272 by ensuring route components are properly destroyed when a router element is disconnected from the DOM. The changes add cleanup logic to prevent memory leaks and ensure proper lifecycle management of routed components.
Key changes:
- Added cleanup in router-slot's disconnectedCallback to clear children and reset route match state
- Applied umbDestroyOnDisconnect directive to workspace elements in modals to ensure proper destruction
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Umbraco.Web.UI.Client/src/packages/core/router/router-slot/router-slot.ts |
Adds clearChildren() and _routeMatch = null to disconnectedCallback to properly destroy child route components when router is disconnected |
src/Umbraco.Web.UI.Client/src/packages/core/workspace/modals/workspace-modal.element.ts |
Applies umbDestroyOnDisconnect() directive to workspace elements to ensure proper cleanup when modal is closed |
madsrasmussen
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21272
Test Notes:
Notice this will destroy a route component when the router element is disconnected. Is there any case where we like to reuse an element despite the router being removed? Or is there a case where a router gets disconnected and reconnected, so the destroy would result in breaking the content of the router?