20595: Missing copy button in media picker#21752
Open
TechPdo wants to merge 3 commits intoumbraco:mainfrom
Open
20595: Missing copy button in media picker#21752TechPdo wants to merge 3 commits intoumbraco:mainfrom
TechPdo wants to merge 3 commits intoumbraco:mainfrom
Conversation
…anges -Added copy icon in media picker which copies the media item into clipboard -Implemented clipboard dialog in the media picker dialog.
… copy again and again and make stack in the clipboard dialog. With this update only one clipboard item per media item will be shown in the clipboard dialog
|
Hi there @TechPdo, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
…ine 18. The underscore prefix marks it as intentionally unused, which satisfies the lint rule. The file now has no linting errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR comes with copy button implmenentation in media picker which was missing in different Umbraco versions after v13. The issue was reported in #20595
-Added copy icon in media picker which copies the media item into clipboard
-Implemented clipboard dialog in the media picker dialog.
To achieve these goals, I added clipboard folder with copy and past functionality typescript files.
Closes #20595