remove unused vars

madsrasmussen · madsrasmussen · commit 8848826cd285 · 2024-07-04T15:51:19.000+02:00
diff --git a/src/libs/element-api/element.test.ts b/src/libs/element-api/element.test.ts
@@ -152,6 +152,7 @@ describe('UmbElementMixin', () => {
 			expect(hostElement.hasUmbController(ctrl)).to.be.true;
 
 			const ctrl2 = hostElement.observe(myObservable, (value) => {
+				// eslint-disable-next-line @typescript-eslint/no-unused-vars
 				const a = value + 'bla';
 			});
 
@@ -172,6 +173,7 @@ describe('UmbElementMixin', () => {
 			const ctrl2 = hostElement.observe(
 				undefined,
 				() => {
+					// eslint-disable-next-line @typescript-eslint/no-unused-vars
 					const a = 1;
 				},
 				'observer',
diff --git a/src/libs/extension-api/controller/base-extension-initializer.controller.test.ts b/src/libs/extension-api/controller/base-extension-initializer.controller.test.ts
@@ -57,12 +57,12 @@ class UmbTestConditionAlwaysInvalid extends UmbControllerBase implements UmbExte
 
 describe('UmbBaseExtensionController', () => {
 	describe('Manifest without conditions', () => {
-		let hostElement: UmbControllerHostElement;
+		//let hostElement: UmbControllerHostElement;
 		let extensionRegistry: UmbExtensionRegistry<ManifestWithDynamicConditions>;
 		let manifest: ManifestWithDynamicConditions;
 
 		beforeEach(async () => {
-			hostElement = await fixture(html`<umb-test-controller-host></umb-test-controller-host>`);
+			//hostElement = await fixture(html`<umb-test-controller-host></umb-test-controller-host>`);
 			extensionRegistry = new UmbExtensionRegistry();
 			manifest = {
 				type: 'section',
@@ -94,12 +94,12 @@ describe('UmbBaseExtensionController', () => {
 	});
 
 	describe('Manifest with empty conditions', () => {
-		let hostElement: UmbControllerHostElement;
+		//let hostElement: UmbControllerHostElement;
 		let extensionRegistry: UmbExtensionRegistry<ManifestWithDynamicConditions>;
 		let manifest: ManifestWithDynamicConditions;
 
 		beforeEach(async () => {
-			hostElement = await fixture(html`<umb-test-controller-host></umb-test-controller-host>`);
+			//hostElement = await fixture(html`<umb-test-controller-host></umb-test-controller-host>`);
 			extensionRegistry = new UmbExtensionRegistry();
 			manifest = {
 				type: 'section',
diff --git a/src/libs/extension-api/controller/extension-element-and-api-initializer.test.ts b/src/libs/extension-api/controller/extension-element-and-api-initializer.test.ts
@@ -1,17 +1,19 @@
 import { UmbExtensionRegistry } from '../registry/extension.registry.js';
 import type { ManifestElementAndApi, ManifestWithDynamicConditions, UmbApi } from '../index.js';
 import { UmbExtensionElementAndApiInitializer } from './extension-element-and-api-initializer.controller.js';
-import { expect, fixture } from '@open-wc/testing';
+import { expect } from '@open-wc/testing';
 import type { UmbControllerHost, UmbControllerHostElement } from '@umbraco-cms/backoffice/controller-api';
 import { UmbControllerHostElementMixin } from '@umbraco-cms/backoffice/controller-api';
-import { customElement, html } from '@umbraco-cms/backoffice/external/lit';
+import { customElement } from '@umbraco-cms/backoffice/external/lit';
 import { UmbSwitchCondition } from '@umbraco-cms/backoffice/extension-registry';
 import { UmbControllerBase } from '@umbraco-cms/backoffice/class-api';
 
 @customElement('umb-test-controller-host')
 class UmbTestControllerHostElement extends UmbControllerHostElementMixin(HTMLElement) {}
 
 @customElement('umb-test-extension-element')
+// Ignoring eslint rule. Element name is used for testing.
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 class UmbTestExtensionElement extends UmbControllerHostElementMixin(HTMLElement) {}
 
 class UmbTestApiController extends UmbControllerBase implements UmbApi {
@@ -35,7 +37,7 @@ describe('UmbExtensionElementAndApiController', () => {
 		let manifest: TestManifest;
 
 		beforeEach(async () => {
-			hostElement = await fixture(html`<umb-test-controller-host></umb-test-controller-host>`);
+			hostElement = new UmbTestControllerHostElement();
 			extensionRegistry = new UmbExtensionRegistry();
 			manifest = {
 				type: 'test-type',
@@ -105,7 +107,7 @@ describe('UmbExtensionElementAndApiController', () => {
 		let manifest: TestManifest;
 
 		beforeEach(async () => {
-			hostElement = await fixture(html`<umb-test-controller-host></umb-test-controller-host>`);
+			hostElement = new UmbTestControllerHostElement();
 			extensionRegistry = new UmbExtensionRegistry();
 
 			manifest = {
@@ -175,7 +177,7 @@ describe('UmbExtensionElementAndApiController', () => {
 		let manifest: TestManifest;
 
 		beforeEach(async () => {
-			hostElement = await fixture(html`<umb-test-controller-host></umb-test-controller-host>`);
+			hostElement = new UmbTestControllerHostElement();
 			extensionRegistry = new UmbExtensionRegistry();
 			manifest = {
 				type: 'test-type',
@@ -238,7 +240,7 @@ describe('UmbExtensionElementAndApiController', () => {
 		let manifest: TestManifest;
 
 		beforeEach(async () => {
-			hostElement = await fixture(html`<umb-test-controller-host></umb-test-controller-host>`);
+			hostElement = new UmbTestControllerHostElement();
 			extensionRegistry = new UmbExtensionRegistry();
 
 			manifest = {
diff --git a/src/libs/extension-api/controller/extension-element-initializer.test.ts b/src/libs/extension-api/controller/extension-element-initializer.test.ts
@@ -15,7 +15,7 @@ describe('UmbExtensionElementController', () => {
 		let manifest: ManifestSection;
 
 		beforeEach(async () => {
-			hostElement = await fixture(html`<umb-test-controller-host></umb-test-controller-host>`);
+			hostElement = new UmbTestControllerHostElement();
 			extensionRegistry = new UmbExtensionRegistry();
 			manifest = {
 				type: 'section',
diff --git a/src/mocks/data/template/template-query.manager.ts b/src/mocks/data/template/template-query.manager.ts
@@ -1,4 +1,4 @@
-import { templateQueryResult, templateQuerySettings, type UmbMockTemplateModel } from './template.data.js';
+import { templateQueryResult, templateQuerySettings } from './template.data.js';
 
 export class UmbMockTemplateQueryManager {
 	constructor() {}
diff --git a/src/mocks/data/webhooks.data.ts b/src/mocks/data/webhooks.data.ts
diff --git a/src/mocks/handlers/dictionary/import-export.handlers.ts b/src/mocks/handlers/dictionary/import-export.handlers.ts
@@ -1,9 +1,10 @@
 const { rest } = window.MockServiceWorker;
-import type { UmbMockDictionaryModel } from '../../data/dictionary/dictionary.data.js';
+//import type { UmbMockDictionaryModel } from '../../data/dictionary/dictionary.data.js';
 import { umbDictionaryMockDb } from '../../data/dictionary/dictionary.db.js';
 import { UMB_SLUG } from './slug.js';
 import { umbracoPath } from '@umbraco-cms/backoffice/utils';
 
+/*
 const importResponse: UmbMockDictionaryModel = {
 	parent: null,
 	name: 'Uploaded dictionary',
@@ -21,6 +22,7 @@ const importResponse: UmbMockDictionaryModel = {
 		},
 	],
 };
+*/
 
 export const importExportHandlers = [
 	rest.post(umbracoPath(`${UMB_SLUG}/import`), async (req, res, ctx) => {
diff --git a/src/mocks/handlers/examine-management.handlers.ts b/src/mocks/handlers/examine-management.handlers.ts
@@ -57,7 +57,6 @@ export const handlers = [
 
 	rest.get(umbracoPath('/searcher/:searcherName/query'), (_req, res, ctx) => {
 		const query = _req.url.searchParams.get('term');
-		const take = _req.url.searchParams.get('take');
 
 		const searcherName = _req.params.searcherName as string;
 
diff --git a/src/packages/block/block-grid/components/block-grid-area-config-entry/workspace/block-grid-area-type-workspace.context.ts b/src/packages/block/block-grid/components/block-grid-area-config-entry/workspace/block-grid-area-type-workspace.context.ts
@@ -106,6 +106,9 @@ export class UmbBlockGridAreaTypeWorkspaceContext
 	getName() {
 		return this.#data.getValue()?.alias;
 	}
+
+	// TODO: [v15] ignoring unused name parameter to avoid breaking changes
+	// eslint-disable-next-line @typescript-eslint/no-unused-vars
 	setName(name: string | undefined) {
 		throw new Error('You cannot set a name of a area-type.');
 	}
diff --git a/src/packages/block/block-grid/context/block-grid-manager.context.ts b/src/packages/block/block-grid/context/block-grid-manager.context.ts
@@ -63,6 +63,8 @@ export class UmbBlockGridManagerContext<
 	create(
 		contentElementTypeKey: string,
 		partialLayoutEntry?: Omit<BlockLayoutType, 'contentUdi'>,
+		// TODO: [v15] Ignore unused parameter to avoid breaking changes
+		// eslint-disable-next-line @typescript-eslint/no-unused-vars
 		modalData?: UmbBlockGridWorkspaceData,
 	) {
 		return super.createBlockData(contentElementTypeKey, partialLayoutEntry);
diff --git a/src/packages/block/block-rte/context/block-rte-manager.context.ts b/src/packages/block/block-rte/context/block-rte-manager.context.ts
@@ -34,6 +34,8 @@ export class UmbBlockRteManagerContext<
 	create(
 		contentElementTypeKey: string,
 		partialLayoutEntry?: Omit<BlockLayoutType, 'contentUdi'>,
+		// TODO: [v15] ignoring unused modalData parameter to avoid breaking changes
+		// eslint-disable-next-line @typescript-eslint/no-unused-vars
 		modalData?: UmbBlockRteWorkspaceData,
 	) {
 		const data = super.createBlockData(contentElementTypeKey, partialLayoutEntry);
diff --git a/src/packages/block/block-rte/tiny-mce-plugin/tiny-mce-block-picker.plugin.ts b/src/packages/block/block-rte/tiny-mce-plugin/tiny-mce-block-picker.plugin.ts
@@ -43,7 +43,7 @@ export default class UmbTinyMceMultiUrlPickerPlugin extends UmbTinyMcePluginBase
 	}
 
 	async showDialog() {
-		const blockEl = this.editor.selection.getNode();
+		//const blockEl = this.editor.selection.getNode();
 
 		/*if (blockEl.nodeName === 'UMB-RTE-BLOCK' || blockEl.nodeName === 'UMB-RTE-BLOCK-INLINE') {
 			const blockUdi = blockEl.getAttribute('data-content-udi') ?? undefined;
diff --git a/src/packages/core/components/table/table.stories.ts b/src/packages/core/components/table/table.stories.ts
@@ -1,8 +1,9 @@
+import type { UmbTableElement, UmbTableColumn, UmbTableItem } from './table.element.js';
 import type { Meta, StoryObj } from '@storybook/web-components';
-import './table.element.js';
-import type { UmbTableElement, UmbTableColumn, UmbTableConfig, UmbTableItem } from './table.element.js';
 import { UmbId } from '@umbraco-cms/backoffice/id';
 
+import './table.element.js';
+
 const meta: Meta<UmbTableElement> = {
 	title: 'Components/Table',
 	component: 'umb-table',
diff --git a/src/packages/documents/documents/entity-actions/create-blueprint/modal/create-blueprint-modal.element.ts b/src/packages/documents/documents/entity-actions/create-blueprint/modal/create-blueprint-modal.element.ts
@@ -3,7 +3,6 @@ import type { UmbCreateBlueprintModalData, UmbCreateBlueprintModalValue } from '
 import { html, customElement, css, state } from '@umbraco-cms/backoffice/external/lit';
 import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
 import { UmbModalBaseElement } from '@umbraco-cms/backoffice/modal';
-import type { UmbDocumentDetailModel } from '@umbraco-cms/backoffice/document';
 import type { UUIInputEvent } from '@umbraco-cms/backoffice/external/uui';
 
 @customElement('umb-create-blueprint-modal')

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { templateQueryResult, templateQuerySettings, type UmbMockTemplateModel } from './template.data.js';`
	`1`	`+import { templateQueryResult, templateQuerySettings } from './template.data.js';`
`2`	`2`
`3`	`3`	`export class UmbMockTemplateQueryManager {`
`4`	`4`	`constructor() {}`
Original file line number	Diff line number	Diff line change
`@@ -106,6 +106,9 @@ export class UmbBlockGridAreaTypeWorkspaceContext`
`106`	`106`	`getName() {`
`107`	`107`	`return this.#data.getValue()?.alias;`
`108`	`108`	`}`
	`109`	`+`
	`110`	`+ // TODO: [v15] ignoring unused name parameter to avoid breaking changes`
	`111`	`+ // eslint-disable-next-line @typescript-eslint/no-unused-vars`
`109`	`112`	`setName(name: string \| undefined) {`
`110`	`113`	`throw new Error('You cannot set a name of a area-type.');`
`111`	`114`	`}`