Merge pull request #141 from umbraco/Release/Patch-220218

Author: nielslyngsoe

.eslintignore

@@ -1 +1,2 @@
 node_modules/
+.eslintrc.js

.eslintrc.js

@@ -10,6 +10,7 @@ module.exports = {
     'plugin:@typescript-eslint/recommended',
     'plugin:lit/recommended',
     'plugin:lit-a11y/recommended',
+    'plugin:storybook/recommended',
   ],
   rules: {
     // disable the rule for all files

.github/workflows/azure-static-web-apps-delightful-beach-055ecb503.yml

@@ -28,8 +28,10 @@ jobs:
         uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node-version }}
-      - run: npm ci
+          cache: 'npm'
+      - run: npm install
       - run: npm run lint
+      - run: npm run test
       - run: npm run build:prod
 
   build_and_deploy_job:

.github/workflows/tests.yml

@@ -30,6 +30,8 @@ jobs:
         uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node-version }}
+          cache: 'npm'
       - run: npm install
       - run: npm run lint
+      - run: npm run test
       - run: npm run build:prod

.gitignore

@@ -27,14 +27,14 @@ tsconfig.tsbuildinfo
 
 
 custom-elements.json
-/packages/uui-css/custom-properties.js
-/packages/uui-css/custom-properties.module.js
+/packages/uui-css/custom-properties.*
 storybook-static
 debug.log
 out-css
 *.log
 .eslintcache
 *.tgz
+.turbo
 
 # old source
-/src/**/*
+/src

.prettierignore

@@ -0,0 +1 @@
+*.hbs

.storybook/main.js

@@ -27,6 +27,7 @@ module.exports = {
       config.optimizeDeps.include.push('lit/directives/style-map.js');
       config.optimizeDeps.include.push('lit/directives/if-defined.js');
       config.optimizeDeps.include.push('lit/directives/unsafe-html.js');
+      config.optimizeDeps.include.push('element-internals-polyfill');
     }
 
     return config;

.storybook/preview-body.html

@@ -1,4 +1,4 @@
 <script>
-  document.body.classList.add('uui-root');
+  document.body.classList.add('uui-font');
   document.body.classList.add('uui-text');
 </script>

.storybook/preview.js

@@ -1,7 +1,7 @@
 import { setCustomElements } from '@storybook/web-components';
 import customElements from '../custom-elements.json';
 import '../packages/uui-css/lib/uui-css.css';
-import 'https://cdn.skypack.dev/element-internals-polyfill';
+import 'element-internals-polyfill';
 
 const sort = (a, b) => {
   if (a[1].name === 'Overview') {

docs/RELEASE_INSTRUCTION.md

@@ -1,18 +1,20 @@
 # UI Library Release workflow
 
-1. Create a new branch for the release. We need a good naming convention: `Release/<patch/minor/major>-<YYMMDD>` (example: `Release/Patch-220128`)
-1. Review new release PR (either [on GitHub](https://github.com/umbraco/Umbraco.UI/compare/) or through `npm run lerna:diff`)
-1. Make a PR from the new branch to the main branch
+1. Create a new branch for the release. We need a good naming convention: `Release/<patch/minor/major>-<YYMMDD>` (example: `Release/Patch-220128`).
+1. Review new release PR (either [on GitHub](https://github.com/umbraco/Umbraco.UI/compare/) or through `npm run lerna:diff`).
+1. Make a PR from the new branch to the main branch.
 1. Wait for GitHub checks to pass.
-1. Run `npm run lerna:version`
-1. Select new version number for every package in the terminal
-1. Confirm the new versions - **this step is irreversible**. It will create tags and commit those to the remote. [Check how to clear tags.](#How-to-clear-tags)
-1. Commit `package-lock.json` to your release branch
+1. Run `npm run lerna:version`.
+1. Select new version number for every package in the terminal.
+1. Confirm the new versions - **this step is irreversible**. It will create tags and commit those to the remote. [Check how to clear tags.](#How-to-clear-tags).
+1. (TODO: Test the new setup works (by adding --no-push and no tag creation)... we haven't tried out jet, but it should fix the problem metnioned below by having a commit without the package-lock begin up to date.. If everything works then remove all tags from repo..).
+1. Commit changes and `package-lock.json` to your release branch.
 1. Wait for GitHub checks to pass. There will be one check that fails and this is the one triggered by a commit made by `npm run lerna:version` command. This fails because it runs build with old `package-lock.json` that does not have updated versions of the packages. After you commit the new package-lock the check should pass.
-1. Merge PR into main - this will trigger two actions - `Publish`, and `Azure Static Web Apps CI/CD`. The `Publish` workflow is responsible for publishing packages to NPM. It will only publish the packages that have higher version that previously published ones. The azure workflow will build and publish UI library Storybook
-1. Merge main branch into dev branch
+1. Github will post a comment with a test link to try out that the release works in Storybook. Please check that it works.
+1. Merge PR into main - this will trigger two actions - `Publish`, and `Azure Static Web Apps CI/CD`. The `Publish` workflow is responsible for publishing packages to NPM. It will only publish the packages that have higher version that previously published ones. The azure workflow will build and publish UI library Storybook.
+1. Merge main branch into dev branch.
 
-## How to clear tags
+## How to clear tags (maybe not relevant after update mentioned above...)
 
 If something goes wrong during the publish workflow, you might end up with tag numbers not corresponding to the current versions of the packages. Tags are stored both on remote and on local repository.