Skip to content

Commit cb03fa8

Browse files
committed
updated release notes with steps for lerna:version with --no-push
1 parent 6fbddfc commit cb03fa8

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

docs/RELEASE_INSTRUCTION.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,9 @@
66
1. Wait for GitHub checks to pass.
77
1. Run `npm run lerna:version`.
88
1. Select new version number for every package in the terminal.
9-
1. Confirm the new versions - **this step is irreversible**. It will create tags and commit those to the remote. [Check how to clear tags.](#How-to-clear-tags).
10-
1. (TODO: Test the new setup works (by adding --no-push and no tag creation)... we haven't tried out jet, but it should fix the problem metnioned below by having a commit without the package-lock begin up to date.. If everything works then remove all tags from repo..).
9+
1. Confirm the new versions.
1110
1. Commit changes and `package-lock.json` to your release branch.
12-
1. Wait for GitHub checks to pass. There will be one check that fails and this is the one triggered by a commit made by `npm run lerna:version` command. This fails because it runs build with old `package-lock.json` that does not have updated versions of the packages. After you commit the new package-lock the check should pass.
11+
1. Wait for GitHub checks to pass.
1312
1. Github will post a comment with a test link to try out that the release works in Storybook. Please check that it works.
1413
1. Merge PR into main - this will trigger two actions - `Publish`, and `Azure Static Web Apps CI/CD`. The `Publish` workflow is responsible for publishing packages to NPM. It will only publish the packages that have higher version that previously published ones. The azure workflow will build and publish UI library Storybook.
1514
1. Merge main branch into dev branch.

0 commit comments

Comments
 (0)