Update adding-language-variants.md #6360

jonathoncove2 · 2024-08-19T08:41:43Z

Added some support for setting cultures in API calls

Description

What did you add/update/change?

Type of suggestion

Product & version (if relevant)

Deadline (if relevant)

When should the content be published?

Added some support for setting cultures in API calls

eshanrnh · 2024-08-19T14:46:24Z

Thanks for the PR, @jonathoncove2 🙌 We will review it as soon as we can. 💪

sofietoft · 2024-08-21T07:29:42Z

Thanks for the PR @jonathoncove2 ! 💪

The "Creating a basic site" tutorial is meant to be very high-level and shouldn't dive into more code than the cshtml and CSS files.
Instead, a fit for this code of yours, could be in the "Creating a multilingual site" instead?
Let me know what you think.
I'll make sure we have the code reviewed in the meantime 💪

jonathoncove2 · 2024-08-21T07:58:12Z

Thanks for looking over this @sofietoft ! I agree that page is a more suitable place for this code. Would you prefer me to make a new PR for this?

I also considered some example code showing how to add a language switching menu, would that be a useful addition?

sofietoft · 2024-08-21T08:24:32Z

Excellent!
No need for a new PR, I think. Just put the code in the other article instead, then we're golden ⭐

It would be amazing with a language switcher 👏
We've actually had that on an internal to-do list for ages, just never had the time to prioritize it.

The "Create a multilingual site" tutorial is a bit long and messy at the moment.
But if you could add your stuff where you think it makes sense, then I'll make sure we give it a look afterward - might need a bit of restructuring and perhaps it could even be split into multiple sub-articles 🤔

Added a guide for creating a basic language switching navigation

jonathoncove2 · 2024-08-21T10:12:49Z

I've removed that API example as requested and added a language switcher. Not sure if my link from adding-language-variants.md works correctly, that might need to be fixed. I've also added sub headers, hopefully to guide users googling the same things I was.

I'm about to go on holiday for a week and half, but feel free to Umbraco-ify the PR and approve it while I'm away.

sofietoft · 2024-08-21T12:06:52Z

Amazing @jonathoncove2 !
I'll make sure we take a look at it as soon as possible 💪

Have a wonderful holiday 🏖️

Frost117

@jonathoncove2 I made some comments about the ILocalizationService, do you think you can rewrite the part but using the ILanguage service instead?

Frost117 · 2024-08-22T08:48:27Z

14/umbraco-cms/tutorials/multilanguage-setup.md

+```csharp
+public class ExampleController : SurfaceController
+{
+    private readonly ILocalizationService _localizationService;


The ILocalizationService is currently marked as obsolete and will be removed in v15. If we decide to keep this one, we have to include a note that the above is obsolete.

Preferably, make this example use the ILanguageService instead

Frost117 · 2024-08-22T08:53:13Z

14/umbraco-cms/tutorials/multilanguage-setup.md

+
+    public IActionResult Index(string culture = null)
+    {
+        IEnumerable<ILanguage> UmbracoLanguages = _localizationService.GetAllLanguages(); //a helpful method to get all configured languages


Something like this could be used instead of calling the database:
https://apidocs.umbraco.com/v14/csharp/api/Umbraco.Cms.Core.Services.ILanguageService.html#Umbraco_Cms_Core_Services_ILanguageService_GetAllAsync

Frost117 · 2024-08-22T09:10:33Z

14/umbraco-cms/tutorials/multilanguage-setup.md

+
+#Getting all the languages for a site 
+
+There are two ways to achive this. One is to use ```localizationService.GetAllLanguages();``` to call the database, which is expensive and ideally includes caching.


We could still keep this part, but instead it would be 3 ways to get the languages.

Then show of each with the not that the localizationService very expensive to do and should only be done if you cannot use the ILanguage service

sofietoft · 2024-10-07T07:35:50Z

Hello @jonathoncove2 👋

Did you notice the review on your PR here? 😄

…rvice Updated the v10 docs to use the original example, as language service is not available

jonathoncove2 · 2024-10-15T08:13:06Z

@sofietoft so sorry about the late response to this.

I've updated the example as suggested, and added the original example to the v10 docs, as the original example is still the most appropriate for that version. I'm not sure when ILanguageService became available, so it might be best to add it to a lower version, you guys will know better than me on that one!

sofietoft · 2024-10-15T08:26:21Z

Perfect, thanks @jonathoncove2 ! 💪

I'll make sure our developer give this a second review.

Frost117

Looks good with the v14 and the updated LanguageService 😃

sofietoft

I've taken the liberty to fix some grammar issues and some typos.
I've also fixed a couple of lists, where each item didn't start with the action word, which prefer 🙌

I was wondering if you could put the steps in the Steps section into an ordered list? Since they are steps, I think it would be nice to format them as such as well 😄

Finally, I've made a suggestion!
I hope it all makes sense. Let me know if something doesn't 💪

sofietoft · 2024-10-29T08:46:22Z

14/umbraco-cms/tutorials/multilanguage-setup.md

+
+You need to replace `{{homeNodeContentAlias}}` with the Document Type alias of your Home node. 
+
+This will look at all the cultures available on the home node, and render links to either the language variant of the current page or the home node for the language variant. If the home node for a language variant is removed, it will not appear in the list.


A suggestion to shorten this sentence a bit.

Suggested change

This will look at all the cultures available on the home node, and render links to either the language variant of the current page or the home node for the language variant. If the home node for a language variant is removed, it will not appear in the list.

This will look at all the cultures available on the home node. Links to either the language variant of the current page or the home node for the language variant will be rendered. If the home node for a language variant is removed, it will not appear in the list.

Shortened a sentence

jonathoncove2 · 2024-10-30T09:17:03Z

Thanks Sophie! Looks like I rely on spell checkers too much 🙈

I've made the changes as you requested

sofietoft · 2024-10-30T09:56:52Z

Looks great @jonathoncove2 ! 😄
Think for applying the suggestions.

I'lle get this merged as soon as the check clears 🙌

jonathoncove2 · 2024-10-30T16:58:43Z

Thanks @sofietoft !

Update adding-language-variants.md

7252a91

Added some support for setting cultures in API calls

eshanrnh added the category/umbraco-cms label Aug 19, 2024

jonathoncove2 added 2 commits August 21, 2024 11:05

Moved API guide to multilanguage-setup.md

53aa7ea

Added a guide for creating a basic language switching navigation

Removed 'easily'

2151348

Frost117 reviewed Aug 22, 2024

View reviewed changes

Updated the multilanguage-setup.md for v14 to include the language se…

0616be0

…rvice Updated the v10 docs to use the original example, as language service is not available

sofietoft requested a review from Frost117 October 15, 2024 08:25

Frost117 approved these changes Oct 28, 2024

View reviewed changes

sofietoft added 3 commits October 29, 2024 09:21

Grammar and typos

8e1434a

Grammar and typos

cf77930

update heading and link

98b27d3

sofietoft reviewed Oct 29, 2024

View reviewed changes

Converted 'steps' into an ordered list

20136c1

Shortened a sentence

Trigger GitBook checks

0f5f0f6

sofietoft merged commit e975476 into umbraco:main Oct 30, 2024
57 of 68 checks passed

sofietoft added a commit that referenced this pull request Nov 6, 2024

Add #6360

31acd31


		#Getting all the languages for a site

		There are two ways to achive this. One is to use ```localizationService.GetAllLanguages();``` to call the database, which is expensive and ideally includes caching.


		You need to replace `{{homeNodeContentAlias}}` with the Document Type alias of your Home node.

		This will look at all the cultures available on the home node, and render links to either the language variant of the current page or the home node for the language variant. If the home node for a language variant is removed, it will not appear in the list.

Update adding-language-variants.md #6360

Update adding-language-variants.md #6360

Uh oh!

Conversation

jonathoncove2 commented Aug 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of suggestion

Product & version (if relevant)

Deadline (if relevant)

Uh oh!

eshanrnh commented Aug 19, 2024

Uh oh!

sofietoft commented Aug 21, 2024

Uh oh!

jonathoncove2 commented Aug 21, 2024

Uh oh!

sofietoft commented Aug 21, 2024

Uh oh!

jonathoncove2 commented Aug 21, 2024

Uh oh!

sofietoft commented Aug 21, 2024

Uh oh!

Frost117 left a comment

Choose a reason for hiding this comment

Uh oh!

Frost117 Aug 22, 2024

Choose a reason for hiding this comment

Uh oh!

Frost117 Aug 22, 2024

Choose a reason for hiding this comment

Uh oh!

Frost117 Aug 22, 2024

Choose a reason for hiding this comment

Uh oh!

sofietoft commented Oct 7, 2024

Uh oh!

jonathoncove2 commented Oct 15, 2024

Uh oh!

sofietoft commented Oct 15, 2024

Uh oh!

Frost117 left a comment

Choose a reason for hiding this comment

Uh oh!

sofietoft left a comment

Choose a reason for hiding this comment

Uh oh!

sofietoft Oct 29, 2024

Choose a reason for hiding this comment

Uh oh!

jonathoncove2 commented Oct 30, 2024

Uh oh!

sofietoft commented Oct 30, 2024

Uh oh!

Uh oh!

jonathoncove2 commented Oct 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jonathoncove2 commented Aug 19, 2024 •

edited

Loading