Skip to content

Conversation

@alina-tincas
Copy link
Contributor

@alina-tincas alina-tincas commented Oct 4, 2024

Description

What did you add/update/change?
update from 13 to 14 as it is v14 docs

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

cms v14

Deadline (if relevant)

When should the content be published?
anytime

update from 13 to 14 as it is v14 docs
Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @alina-tincas !

Instead of mentioning the specific .NET version, which we already do in the requirements above, why not just link to the generic Windows installation docs: https://learn.microsoft.com/en-us/dotnet/core/install/windows
Then we can also get rid of the note!

What do you think?

@alina-tincas
Copy link
Contributor Author

I think in this case it might be best to just remove the note and leave the link as it is, because the one at the top was requirements for local solution while the one I tried to change was for hosting umbraco.

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final change 😅

@sofietoft sofietoft merged commit 74b29b6 into main Oct 7, 2024
@sofietoft sofietoft deleted the alina-tincas-patch-1 branch October 9, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants