-
Notifications
You must be signed in to change notification settings - Fork 812
Create add-item article #6521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create add-item article #6521
Conversation
Original article for adding an item to a cart when using Umbraco Commerce
|
Thanks for the PR @MrEssCee ! 💪 We'll make sure to get this reviewed as soon as possible. |
umbracotrd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sofietoft : Fix syntax in code example
Co-authored-by: Dinh Tran <[email protected]>
Co-authored-by: Dinh Tran <[email protected]>
Co-authored-by: Dinh Tran <[email protected]>
Co-authored-by: Dinh Tran <[email protected]>
Co-authored-by: Dinh Tran <[email protected]>
Co-authored-by: Dinh Tran <[email protected]>
Co-authored-by: Dinh Tran <[email protected]>
Co-authored-by: Dinh Tran <[email protected]>
Hint removed
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great guide! 💪
I've taken the liberty to correct some grammar and apply our style guide to the article.
Also, could you look into adding the code snippets to code blocks, using the following docs: https://docs.gitbook.com/content-editor/blocks/code-block#representation-in-markdown
Don't mind about the line numbers and the wrap, but adding the file name would be great 🙌
Also, I've asked a question regarding the properties on the Document Type.
Hope it all makes sense!
|
Also realized that the file name here is a bit wrong. |
|
Could you also add the article to the SUMMARY file? If it's not added to the SUMMARY file, it will not be part of the published docs. |
Added property editors
renamed 👍 |
|
Thanks for applying the suggestions @MrEssCee ! 💪 I've taken the liberty to add the article in this PR to the SUMMARY file for 13/commerce. Are you up for adding the other articles to the SUMMARY as well? |
Updated Summary
@sofietoft I think i did this in
Completed 👍 |
|
Looks great @MrEssCee ! 💪 We'll not be able to preview the other articles you've added, but it looks like all checks out in the Markdown department. Thanks again for all the word you've put in here. |
Original article for adding an item to a cart when using Umbraco Commerce
Description
How to add an item to the Umbraco Commerce cart
What did you add/update/change?
Type of suggestion
Product & version (if relevant)
Umbraco 13
Deadline (if relevant)
When should the content be published?
ASAP