Skip to content

Conversation

@mr-shellychauhan
Copy link
Contributor

Original article for adding an item to a cart when using Umbraco Commerce

Description

How to add an item to the Umbraco Commerce cart

What did you add/update/change?

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Umbraco 13

Deadline (if relevant)

When should the content be published?
ASAP

Original article for adding an item to a cart when using Umbraco Commerce
@sofietoft sofietoft mentioned this pull request Oct 7, 2024
4 tasks
@sofietoft sofietoft added review/developer Use this label if an internal developer review is required category/umbraco-commerce labels Oct 7, 2024
@sofietoft
Copy link
Contributor

Thanks for the PR @MrEssCee ! 💪

We'll make sure to get this reviewed as soon as possible.

Copy link
Contributor

@umbracotrd umbracotrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sofietoft : Fix syntax in code example

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great guide! 💪
I've taken the liberty to correct some grammar and apply our style guide to the article.

Also, could you look into adding the code snippets to code blocks, using the following docs: https://docs.gitbook.com/content-editor/blocks/code-block#representation-in-markdown
Don't mind about the line numbers and the wrap, but adding the file name would be great 🙌

Also, I've asked a question regarding the properties on the Document Type.

Hope it all makes sense!

@sofietoft
Copy link
Contributor

Also realized that the file name here is a bit wrong.
It needs to have the .md file extension to work with our docs 🙌

@sofietoft
Copy link
Contributor

Could you also add the article to the SUMMARY file?
Go up in the file structure and file the closest SUMMARY.md file - that will be for this version of the Commerce docs.
Add a link to this article, using the title of the article as the link title 💪

If it's not added to the SUMMARY file, it will not be part of the published docs.
Happy to do this as well - just let me know.

@mr-shellychauhan
Copy link
Contributor Author

mr-shellychauhan commented Oct 8, 2024

Also realized that the file name here is a bit wrong. It needs to have the .md file extension to work with our docs 🙌

renamed 👍

@sofietoft
Copy link
Contributor

Thanks for applying the suggestions @MrEssCee ! 💪

I've taken the liberty to add the article in this PR to the SUMMARY file for 13/commerce.
Now we can also preview the article in the docs - use the GitBook link with docs.umbraco.com in the Checks window below.

Are you up for adding the other articles to the SUMMARY as well?
It would be best if you can do it in the same PR as the article - that will let us use the preview 😁

Updated Summary
@mr-shellychauhan
Copy link
Contributor Author

Thanks for applying the suggestions @MrEssCee ! 💪

I've taken the liberty to add the article in this PR to the SUMMARY file for 13/commerce. Now we can also preview the article in the docs - use the GitBook link with docs.umbraco.com in the Checks window below.

Are you up for adding the other articles to the SUMMARY as well? It would be best if you can do it in the same PR as the article - that will let us use the preview 😁

@sofietoft I think i did this in

Thanks for applying the suggestions @MrEssCee ! 💪

I've taken the liberty to add the article in this PR to the SUMMARY file for 13/commerce. Now we can also preview the article in the docs - use the GitBook link with docs.umbraco.com in the Checks window below.

Are you up for adding the other articles to the SUMMARY as well? It would be best if you can do it in the same PR as the article - that will let us use the preview 😁

Completed 👍

@sofietoft
Copy link
Contributor

Looks great @MrEssCee ! 💪

We'll not be able to preview the other articles you've added, but it looks like all checks out in the Markdown department.
Once the PR with the delete article gives all green lights on the checks I'll start merging these in 💪

Thanks again for all the word you've put in here.
It will be SO great to finally have some more Commerce guide in our docs 😄 🎉

@sofietoft sofietoft merged commit f7e2455 into umbraco:main Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants