Porting old Umbraco API Controller [Mapping] #6529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR @erikjanwestendorp ! 🎉 I'll make sure we review this as soon as possible! |
sofietoft
reviewed
Oct 8, 2024
Contributor
sofietoft
left a comment
sofietoft
left a comment
There was a problem hiding this comment.
I've been testing this now, and cannot get it to compile even without the changes you're making here.
It's complaining about the CreateResponse method 🤔
I think I might need to send this past our developers, for a check.
Any chance you ran into similar issues when testing?
Contributor
Author
|
@sofietoft My bad.. 🐵, I didn't copy all my changes from my solution to the docs. Indeed you have to change the return type to |
Contributor
|
Ah, that happens! 😄 No worries. Everything compiles now 👏 Thanks again for putting in the effort to help us get this updated! I'll make sure it's merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR belongs to: #6466.
Type of suggestion
Product & version (if relevant)
Umbraco CMS v14 & 15