-
Notifications
You must be signed in to change notification settings - Fork 813
V15: Cache seeding docs #6578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V15: Cache seeding docs #6578
Conversation
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were quite a few too long sentences in the articles here, so I took the liberty to make changes directly to the PR 🙈 felt that was a bit quicker.
Please give it a look and let me know if something doesn't look right! 🙌
Besides grammar, readability, and typos, I've also made some suggestions.
For the Extending article, I suggest we make that into a step-by-step guide! 🤞
Finally, three new articles are added with this PR and one is removed.
This means we need to do a few more things here:
- Add the new articles to the SUMMARY file
- Add a redirect for the deleted article (I suggest we redirect to the new cache-settings.md article, and add a note at the top of that article to explain why the nucachesettings article is done.
Let me know if you prefer that I handle added the redirect and the SUMMARY entries - I'd be happy to! 🙌
Co-authored-by: sofietoft <[email protected]>
|
Thank you 🙌 Brevity is not my forté 🙈 not sure how the whole redirect thing works, so would be great if you can handle that 😄 |
|
I've added the new articles to the SUMMARY file and made the redirects. Before I merge, can you help me confirm whether it's OK to redirect the NuCache settings article to the new Cache Settings article? 🤔 Or should I redirect it somewhere else? |
|
Awesome, thanks 🙌 Yes I think it makes a lot of sense to redirect it to the new cache settings article, since NuCache no longer exists, and has been replaced by the new cache 😄 |
|
Great! Actually, now that I think about it - I'll add a little note to the new article. |
|
@nikolajlauridsen - When you have a spare minute, could you take a look at this commit: 12c0fc8 🤞 Just want to make sure I got it right! |
|
That looks perfect to me, thanks 😄👌 |
|
Excellent! Then I think this is finally ready 💪 You're releasing RC-3 next week, right? |
|
Yeps, it's targeted for next week 😄 |
|
Also, this is a bit odd, but I've had to extend the article with some additional information, not sure what's the easiest workflow for you, but I've made a separate PR here nikolajlauridsen#1 Migrating this will update this PR, but I thought it might be easier to only review the new changes alone, but since I don't have commit rights to this repo it had to be on my own, please let me know if I need to do something different 😄 |
…tes-settings V15: Add maximumpayload bytes settings
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes looks good @nikolajlauridsen !
I've added a suggestion for a small rewrite - let me know what you think!
Description
Type of suggestion
Product & version (if relevant)
CMS V15
When should the content be published?
When V15-RC3 is released (The articles contains information about configuration that's not there until then)