Skip to content

Conversation

@jacksorjacksor
Copy link
Contributor

Have done this for Umbraco 15 docs only. Can go back through earlier docs and copy/paste in the updates if the points are relevant there too.

Description

common-pitfalls.md

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Umbraco 15 (and earlier)

Deadline (if relevant)

N/A

Have done this for Umbraco 15 docs only. Can go back through earlier docs and copy/paste in the updates if the points are relevant there too.
@sofietoft
Copy link
Contributor

Thanks for the PR @jacksorjacksor !
I'll make sure we get it reviewed as soon as possible!

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jacksorjacksor ! 💪

I've made a single suggestion.

Sounds good! Thanks Sofie!

Co-authored-by: sofietoft <[email protected]>
@jacksorjacksor
Copy link
Contributor Author

@sofietoft um.... what do we do if these two checks have been pending for a long while....?

@sofietoft
Copy link
Contributor

Good question @jacksorjacksor !
Adding a commit to the PR will trigger the checks, so this is what I usually do.

I'm currently not aware of why some of these checks never complete (it happens A LOT!), but I'm pretty sure it's on GitBooks end.

Looks like another commit here turned all the checks green 😁
I'll get this merged!

Thanks again 🙌

@sofietoft sofietoft merged commit 98619c3 into umbraco:main Oct 30, 2024
13 checks passed
@jacksorjacksor
Copy link
Contributor Author

Thanks @sofietoft !! Always a pleasure to contribute!

@jacksorjacksor jacksorjacksor deleted the patch-10 branch October 30, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants