-
Notifications
You must be signed in to change notification settings - Fork 813
404 Page Tutorial Fix #6605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 Page Tutorial Fix #6605
Conversation
…allowed by the CMS.
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @bszyman ! 💪
Super to get this updated 😄
I've added a single suggestion.
| 2. Create a new "_Document Type with Template_". | ||
| 3. Name the Document Type **404**. | ||
| 3. Name the Document Type **404 Page**. | ||
| 1. Note: By default, Umbraco will generate the alias for this DocType as simply "Page," omitting the "404." You may want to manually adjust the alias to "404Page." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding a new step for actually updating the alias instead?
Like, "4. Change the alias to **Page404**" or something similar.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sofietoft What if I told you that I completely agree, on re-reading this the second time though? :)
I added a step 4 and updated the rest of the sequence. I also left a note on step 4 to give the "why." It feels awkward maybe, but I think it's important to tell people why they need to do this.
Submitted a change, LMK what you think!
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @bszyman !
I agree that it is a good idea to explain why the alias needs to be updated 💪
I've made a tiny suggestion - let me know if something doesn't make sense!
Co-authored-by: sofietoft <[email protected]>
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @bszyman !
Let's get this one merged 😁
|
Hi there @bszyman! First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇 Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉 In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you! As an alternative choice, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳 Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 25th, 2024, 23:59:00 UTC. Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few weeks/months, so please bear with us and be patient 🙏 The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help! Kind regards, |
|
@bszyman Good day! You still have a few days to let us know what you want for Hacktoberfest 🎁, we'd love it if it was an active choice! Thanks! |

Description
The "Implement Custom Error Pages" tutorial instructs users to create a doc type with the name "404."
3. Name the Document Type 404.This is an invalid name, and the CMS will not allow the user to create/save the new doc type.
I reworked the existing content to instruct users to name the doc type "404 Page" and manually set the alias to "404Page."
This should tighten up the tutorial and add a little clarity with what the CMS does/doesn't allow.
Type of suggestion
Product & version (if relevant)
v14
Deadline (if relevant)
N/A