-
Notifications
You must be signed in to change notification settings - Fork 811
Update README.md #6609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #6609
Conversation
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @jonathoncove2 !
I've made some tiny suggestions. Let me know if something doesn't look right.
|
Thanks for the tweaks! All looks good to me |
|
Thanks for considering the suggestions @jonathoncove2 ! 💪 Would it make sense to add a little more context to this code sample? |
|
Hi @jonathoncove2 ! Did you see my previous message? 😄 |
Added a better explanation of when to use the code
|
Apologies @sofietoft , I've made some edits now which give some more detail. Likely needs umbraco-ifying a bit |
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @jonathoncove2 ! 😄 Thanks.
I've made a suggestion - should shorten the sentence, but let me know if you think it still makes sense!
|
Thanks for considering the suggestion @jonathoncove2 ! 😄 Looks like we're ready to merge this one. |
|
Hi there @jonathoncove2! First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇 Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉 In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you! As an alternative choice, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳 Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 25th, 2024, 23:59:00 UTC. Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few weeks/months, so please bear with us and be patient 🙏 The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help! Kind regards, |
|
@jonathoncove2 Good day! You still have a few days to let us know what you want for Hacktoberfest 🎁, we'd love it if it was an active choice! Thanks! |

Description
Added a brief example on adding messages to a notification
Type of suggestion
Product & version (if relevant)
v10
Deadline (if relevant)
N/A