Reworded warning for clarity #6620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

eshanrnh merged 8 commits into main from eshanrnh-patch-2

Nov 6, 2024

Contributor

eshanrnh commented Nov 5, 2024 •

edited

Loading

Description

As per issue #6586, updated the note to specify that the conflict with Entra ID only applies to backoffice logins, not member logins. Added a line about the upcoming feature (WIP) which might remove this limitation.

Type of suggestion

Product & version (if relevant)

CMS v14.

Deadline (if relevant)

Anytime


          Reworded warning for clarity

a455496

eshanrnh added the category/umbraco-cms label

eshanrnh commented

View reviewed changes

14/umbraco-cms/tutorials/add-microsoft-entra-id-authentication.md Outdated Show resolved Hide resolved

eshanrnh commented

View reviewed changes

14/umbraco-cms/tutorials/add-microsoft-entra-id-authentication.md Outdated Show resolved Hide resolved

eshanrnh commented

View reviewed changes

14/umbraco-cms/tutorials/add-microsoft-entra-id-authentication.md Outdated Show resolved Hide resolved

eshanrnh added 3 commits

November 5, 2024 13:00


          Update 14/umbraco-cms/tutorials/add-microsoft-entra-id-authentication.md


          Update 14/umbraco-cms/tutorials/add-microsoft-entra-id-authentication.md

d329cee


          Update 14/umbraco-cms/tutorials/add-microsoft-entra-id-authentication.md

3d91822

eshanrnh commented

View reviewed changes

14/umbraco-cms/tutorials/add-microsoft-entra-id-authentication.md Outdated Show resolved Hide resolved


          Update 14/umbraco-cms/tutorials/add-microsoft-entra-id-authentication.md

eshanrnh commented

View reviewed changes

14/umbraco-cms/tutorials/add-microsoft-entra-id-authentication.md Outdated Show resolved Hide resolved


          Update 14/umbraco-cms/tutorials/add-microsoft-entra-id-authentication.md

43e10fa

eshanrnh commented

View reviewed changes

14/umbraco-cms/tutorials/add-microsoft-entra-id-authentication.md Outdated Show resolved Hide resolved


          Update 14/umbraco-cms/tutorials/add-microsoft-entra-id-authentication.md

96e9983

sofietoft reviewed

View reviewed changes

Contributor

sofietoft left a comment

Looks great @eshanrnh !

I'm not sure about the note about the upcoming feature on Cloud.
It's a temporary note that we will somehow need to keep track of, to make sure we remove it once the feature is actually launched 🤔

eshanrnh commented

View reviewed changes

14/umbraco-cms/tutorials/add-microsoft-entra-id-authentication.md Outdated Show resolved Hide resolved


          Update 14/umbraco-cms/tutorials/add-microsoft-entra-id-authentication.md

bebdead

Contributor Author

eshanrnh commented Nov 5, 2024

I removed the line about the upcoming feature but I believe even the Note will have to be removed once the feature is released since then Entra ID will be compatible with backoffice users as well.

Contributor

sofietoft commented Nov 5, 2024

I removed the line about the upcoming feature but I believe even the Note will have to be removed once the feature is released since then Entra ID will be compatible with backoffice users as well.

Yes, that's a good point!
Let's talk about how we can keep track of this somehow, so we remember to remove it once the feature is out 💪

sofietoft approved these changes

View reviewed changes

eshanrnh merged commit f81a463 into main

7 checks passed

eshanrnh deleted the eshanrnh-patch-2 branch

November 21, 2024 10:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category/umbraco-cms