Skip to content

Updated accepted prefix with new one for products #6674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Updated accepted prefix with new one for products #6674

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
786ef85
Updated accepted prefix with new one for products
jonat123 Nov 15, 2024
939aec8
Updates based on review comments
sofietoft Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions umbraco-cloud/set-up/project-settings/secrets-management.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ While we have a number of prefixes that are not accepted, we do allow the use of
* `Umbraco__Forms__FieldTypes__Recaptcha`
* `Umbraco__CMS__Integrations`
* `Umbraco__CMS__DeliveryAPI`
* `UMBRACO__LICENSES__YOURPRODUCT`
Copy link
Member

@pijemcolu pijemcolu Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `UMBRACO__LICENSES__YOURPRODUCT`
* `UMBRACO__LICENSES__`

Copy link
Contributor Author

@jonat123 jonat123 Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pijemcolu wouldnt it be more clear to customers that they can add it for the different products with YOURPRODUCT at the end?

They might want to have more than one license in their projects.

Copy link
Contributor

@sofietoft sofietoft Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do UMBRACO__LICENSES__XX as an alternative.
And then in a note below, we mention how to replace XX with the product name and give an example or two?

Copy link
Member

@pijemcolu pijemcolu Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a set of prefixes. This is a set of prefixes (Ok, we can improve slightly by suffixing all prefixes by __ )

* `Umbraco__CMS__Global__Smtp__`
* `Umbraco__Forms__Security__FormsApiKey`
* `Umbraco__Forms__FieldTypes__Recaptcha`
* `Umbraco__CMS__Integrations`
* `Umbraco__CMS__DeliveryAPI`
* `UMBRACO__LICENSES`

Either they're all prefixes, or we shall adjust all of the above to be something such as:

* `Umbraco__CMS__Global__Smtp__*`
* `Umbraco__Forms__Security__FormsApiKey__*`
* `Umbraco__Forms__FieldTypes__Recaptcha__*`
* `Umbraco__CMS__Integrations__*`
* `Umbraco__CMS__DeliveryAPI__*`
* `UMBRACO__LICENSES__*`

Copy link
Contributor

@sofietoft sofietoft Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool! 💪
So anything can be added after the prefix? Is that correctly understood?
I could do something like UMBRACO__LICENSES__MyCoolUmbracoLicense ? 😅

Copy link
Member

@pijemcolu pijemcolu Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the way this is coded within the Umbraco Cloud platform, you can add any string behind these prefixes.

* `Umbraco__CMS__Global__Smtp__`
* `Umbraco__Forms__Security__FormsApiKey`
* `Umbraco__Forms__FieldTypes__Recaptcha`
* `Umbraco__CMS__Integrations`
* `Umbraco__CMS__DeliveryAPI`
* `UMBRACO__LICENSES`

Copy link
Contributor

@sofietoft sofietoft Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Let's keep that format then 💪
@jonat123 - you up for making the changes to the PR?


It is also possible to use Secrets to save API keys, Passwords, and ReChaptcha for all our Umbraco products on Umbraco Cloud.

Expand Down
Loading