Skip to content

Conversation

@AndyButland
Copy link
Contributor

Description

Described option for using underscores in product keys when configuring product licenses with environment variables.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Commerce, UI Builder, Engage and Deploy (on-premise)

Deadline (if relevant)

Any time.

…ng product licenses with environment variables.
```

{% hint style="info" %}
If using environment variables rather than a JSON file for configuration you may run into issues with the periods used in the product key. If so, an underscore can be used instead:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this, an potentially the rest, be stripped down to this? Or is it lacking too much detail? 🤔

Suggested change
If using environment variables rather than a JSON file for configuration you may run into issues with the periods used in the product key. If so, an underscore can be used instead:
Use an underscore in the product name, to avoid issues when using environment variables.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be OK, but the detail is kind of useful too for background, and also as we've documented above using the ".".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I see 🤔

How about:

"When using environment variables you might run into issues when using a period in the product name. Use an underscore in the product name instead, to avoid issues."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine, do you want me to make that update or will you do so?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can update the notes 💪

@sofietoft sofietoft merged commit 22b7878 into main Dec 16, 2024
39 of 43 checks passed
@AndyButland AndyButland deleted the licensing/use-underscore branch December 17, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants