-
Notifications
You must be signed in to change notification settings - Fork 811
Confirm Dialog Updates #7327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm Dialog Updates #7327
Conversation
|
Hey @sofietoft - wrt your comment on #7319 (comment), I created a new, cleaner PR. No conflicts! |
|
Thanks @bszyman ! π And sorry for the inconvenience! |
16/umbraco-cms/customizing/extending-overview/extension-types/modals/confirm-dialog.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/customizing/extending-overview/extension-types/modals/confirm-dialog.md
Show resolved
Hide resolved
iOvergaard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to discuss a few things with this article:
Location
Currently, the article resides in "extension types/modals", but it's not really an extension type in itself, although it uses the extension type called "modal".
Should we perhaps find a more fitting location for this article and other such helper functions like this umbOpenModal and others?
I am not sure where that could be, but it feels to me like we need a universe for "developer experience", or how to make the developers' lives easier :-)
umbOpenModal vs umbConfirmModal
It seems to me that this article describes only the helper function called umbOpenModal(), where you must import a modal token called UMB_CONFIRM_MODAL to open the confirm modal.
Did you know that we have a function straight out called umbConfirmModal()?
It does the same thing without having to import the token, and it accepts the same data object as described here. Although it is nice to see the regular open modal described, I think this function is more fitting to use in this article.
# Conflicts: # 14/umbraco-cms/customizing/extending-overview/extension-types/modals/confirm-dialog.md
|
We will approve this, Ben has made a task to follow up on the structural perspective and also add additional content regarding the two helper methods, open-modal and confirm-modal. |
π Description
Refine "Modals" documentation: updated confirm dialog behavior and usage examples.
π Related Issues (if applicable)
#7319
β Contributor Checklist
I've followed the Umbraco Documentation Style Guide and can confirm that:
Product & Version (if relevant)
v16
Deadline (if relevant)
N/A
π Helpful Resources