Skip to content

Conversation

@bszyman
Copy link
Contributor

@bszyman bszyman commented Aug 20, 2025

πŸ“‹ Description

Refine "Modals" documentation: updated confirm dialog behavior and usage examples.

πŸ“Ž Related Issues (if applicable)

#7319

βœ… Contributor Checklist

I've followed the Umbraco Documentation Style Guide and can confirm that:

  • Code blocks are correctly formatted.
  • Sentences are short and clear (preferably under 25 words).
  • Passive voice and first-person language (β€œwe”, β€œI”) are avoided.
  • Relevant pages are linked.
  • All links work and point to the correct resources.
  • Screenshots or diagrams are included if useful.
  • Any code examples or instructions have been tested.
  • Typos, broken links, and broken images are fixed.

Product & Version (if relevant)

v16

Deadline (if relevant)

N/A

πŸ“š Helpful Resources

@bszyman
Copy link
Contributor Author

bszyman commented Aug 20, 2025

Hey @sofietoft - wrt your comment on #7319 (comment), I created a new, cleaner PR. No conflicts!

@sofietoft
Copy link
Contributor

Thanks @bszyman ! πŸ™

And sorry for the inconvenience!
We're looking into it from our side, how we can avoid this in the future.
We might also discuss on our next meeting (Tuesday, I believe!).

Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to discuss a few things with this article:

Location

Currently, the article resides in "extension types/modals", but it's not really an extension type in itself, although it uses the extension type called "modal".

Image

Should we perhaps find a more fitting location for this article and other such helper functions like this umbOpenModal and others?
I am not sure where that could be, but it feels to me like we need a universe for "developer experience", or how to make the developers' lives easier :-)

umbOpenModal vs umbConfirmModal

It seems to me that this article describes only the helper function called umbOpenModal(), where you must import a modal token called UMB_CONFIRM_MODAL to open the confirm modal.

Did you know that we have a function straight out called umbConfirmModal()?
It does the same thing without having to import the token, and it accepts the same data object as described here. Although it is nice to see the regular open modal described, I think this function is more fitting to use in this article.

# Conflicts:
#	14/umbraco-cms/customizing/extending-overview/extension-types/modals/confirm-dialog.md
@nielslyngsoe
Copy link
Member

We will approve this, Ben has made a task to follow up on the structural perspective and also add additional content regarding the two helper methods, open-modal and confirm-modal.

@nielslyngsoe nielslyngsoe merged commit 55303c5 into umbraco:main Sep 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants