-
Notifications
You must be signed in to change notification settings - Fork 811
Update documentation and codesamples for upload field, multiurl picker and richtext mce #7446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The integer IDs are no longer surfaced in the backoffice UI, and the GUID is now referred to as the content node's `Id`.
Use familiar "With Models Builder" & "Without Models Builder" pattern
Also removes the reference to using the integer Ids
mikecp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...ms/fundamentals/backoffice/property-editors/built-in-umbraco-property-editors/file-upload.md
Show resolved
Hide resolved
...ms/fundamentals/backoffice/property-editors/built-in-umbraco-property-editors/file-upload.md
Show resolved
Hide resolved
...office/property-editors/built-in-umbraco-property-editors/rich-text-editor-tinymce/README.md
Outdated
Show resolved
Hide resolved
...office/property-editors/built-in-umbraco-property-editors/rich-text-editor-tinymce/README.md
Show resolved
Hide resolved
...ndamentals/backoffice/property-editors/built-in-umbraco-property-editors/multi-url-picker.md
Outdated
Show resolved
Hide resolved
...ndamentals/backoffice/property-editors/built-in-umbraco-property-editors/multi-url-picker.md
Outdated
Show resolved
Hide resolved
...ndamentals/backoffice/property-editors/built-in-umbraco-property-editors/multi-url-picker.md
Outdated
Show resolved
Hide resolved
...ndamentals/backoffice/property-editors/built-in-umbraco-property-editors/multi-url-picker.md
Outdated
Show resolved
Hide resolved
...ndamentals/backoffice/property-editors/built-in-umbraco-property-editors/multi-url-picker.md
Show resolved
Hide resolved
...ndamentals/backoffice/property-editors/built-in-umbraco-property-editors/multi-url-picker.md
Outdated
Show resolved
Hide resolved
β¦in-umbraco-property-editors/rich-text-editor-tinymce/README.md Co-authored-by: Michael Latouche <[email protected]>
β¦e/UmbracoDocs into issue-7220-upload-field
|
I've pushed changes for all but one of your suggestions @mikecp β I'll just create the new screenshot and add that as well. Thanks β /Chriztian |
AndyButland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks very good and correct to me, thanks very much @greystate and @mikecp.
Only think I'd note is that we'd want these changes copied to the 17 folder. Maybe one of you could do that or @eshanrnh will when she reviews, but just want to make sure it's not forgotten.
eshanrnh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks great. Just a minor suggestion to format the intro block.
@AndyButland I will copy the changes over to v17. No problem :)
π Description
Update main pages for UploadField, MultiUrlPicker and RichText TinyMCE property editors, for versions 15 and 16.
π Related Issues (if applicable)
Fixes #7270
β Contributor Checklist
I've followed the Umbraco Documentation Style Guide and can confirm that:
Product & Version (if relevant)
This applies to version 15 and 16
π Helpful Resources