-
Notifications
You must be signed in to change notification settings - Fork 811
Register an entitySign and render an icon. #7457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AndyButland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @engijlr. I suggested a few small updates, partially addressing @nielslyngsoe's point in the copy.
I think it would be nice to present a second example under a heading like "Example: Rendering an Entity Sign with Custom Logic" where you show how to render a backoffice sign without server input. Presumably this won't have a forEntityFlags setting but will have a referenced .ts file where the logic is implemented. That'll handle the rest of Niel's point about showing that this isn't just an extension that depends on the data coming from the management API.
Maybe you can think of a good real-world example, but even an illustrative one adding a sign for any document that has been created in the last week would suffice. The create date for a document I believe is in the tree item response model, so you could read if from there,
AndyButland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, all looks good from my perspective @engijlr,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks great.
@engijlr is there a specific date you would like this PR published or can it be published anytime?
|
Hi @eshanrnh, |
|
I agree, it can be published now. And actually @eshanrnh, if you could do as soon as you can please, that would be great (as I linked to this page in the docs expecting the updates to be there in today's blog post π). |
π Description
This PR explains how to register an entitySign, bind it with forEntityFlags, and render an icon.
π Related Issues (if applicable)
Relates to PR: umbraco/Umbraco-CMS#20328
β Contributor Checklist
I've followed the Umbraco Documentation Style Guide and can confirm that:
Product & Version (if relevant)
CMS 16.4/17
Deadline (if relevant)
Expect this to be published along with the RC for 16.4 or 17.