Skip to content

Conversation

@MiguelLopez6
Copy link
Contributor

📋 Description

In the example code for custom discount reward provider, the attributes used on the properties of the TieredPercentageSettings class are wrong. They are of type DiscountRuleProviderSetting, but they should be DiscountRewardProviderSetting.

📎 Related Issues

Fixes #7513

✅ Contributor Checklist

I've followed the Umbraco Documentation Style Guide and can confirm that:

  • [✅] Code blocks are correctly formatted.
  • [✅] Sentences are short and clear (preferably under 25 words).
  • [✅] Passive voice and first-person language (“we”, “I”) are avoided.
  • [✅] Relevant pages are linked.
  • [✅] All links work and point to the correct resources.
  • [✅] Screenshots or diagrams are included if useful.
  • [✅] Any code examples or instructions have been tested.
  • [✅] Typos, broken links, and broken images are fixed.

Product & Version (if relevant)

16

Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @MiguelLopez6 🙌 Thanks again for spotting and fixing it 💪

@eshanrnh eshanrnh merged commit dbb5e9b into umbraco:main Oct 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Umbraco Commerce > Discount rules and rewards

2 participants