-
Notifications
You must be signed in to change notification settings - Fork 811
Updated create a block grid programatically section of "Block Grid" page #7607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@AndyButland is this ready for internal or docs review? Asking cz the task is in internal community review status π |
|
You can review this one please @eshanrnh. It's an update to part of a page that HQ were asked to look into, where there rest of the page is being handled by a community team member. So it won't close the linked issue, rather is just related to it. |
eshanrnh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @AndyButland π The PR looks good.
I have added suggestions to start the steps/list with an action word and cleaned up the long, messy image URLs. I'll take care of those.
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-grid-editor.md
Outdated
Show resolved
Hide resolved
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-grid-editor.md
Outdated
Show resolved
Hide resolved
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-grid-editor.md
Outdated
Show resolved
Hide resolved
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-grid-editor.md
Outdated
Show resolved
Hide resolved
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-grid-editor.md
Outdated
Show resolved
Hide resolved
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-grid-editor.md
Outdated
Show resolved
Hide resolved
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-grid-editor.md
Outdated
Show resolved
Hide resolved
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-grid-editor.md
Outdated
Show resolved
Hide resolved
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-grid-editor.md
Outdated
Show resolved
Hide resolved
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-grid-editor.md
Outdated
Show resolved
Hide resolved
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-grid-editor.md
Outdated
Show resolved
Hide resolved
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-grid-editor.md
Outdated
Show resolved
Hide resolved
|
The Link Checker found broken links in your PR. Broken links found in: 16/umbraco-cms/fundamentals/setup/upgrading/version-specific/README.md β Unknown error β [500] https://our.umbraco.com/download/releases/1300 |#124; Rejected status code (this depends on your "accept" configuration): Internal Server Error |
π Description
This PR updates the code sample and instructions for the "Creating a Block Grid programmatically" on the "Block Grid" page
π Related Issues (if applicable)
#7599
β Contributor Checklist
I've followed the Umbraco Documentation Style Guide and can confirm that:
Product & Version (if relevant)
CMS 16 and 17
Deadline (if relevant)
Can be reviewed and published at any time.