Skip to content

Conversation

@busrasengul
Copy link
Contributor

@busrasengul busrasengul commented Dec 3, 2025

πŸ“‹ Description

Updating Customizing, Property Editor

πŸ“Ž Related Issues (if applicable)

βœ… Contributor Checklist

I've followed the Umbraco Documentation Style Guide and can confirm that:

  • [ x ] Sentences are short and clear (preferably under 25 words).
  • [ x ] Passive voice and first-person language (β€œwe”, β€œI”) are avoided.
  • [ x ] Relevant pages are linked.
  • [ x ] All links work and point to the correct resources.
  • [ x ] Typos, broken links, and broken images are fixed.

Product & Version (if relevant)

v17, v16

Issue #7688

@busrasengul busrasengul marked this pull request as ready for review December 3, 2025 09:41
@Luuk1983
Copy link
Contributor

Luuk1983 commented Dec 3, 2025

The order of the menu items is different than what's on your page:

image

Consider streamlining this. I think both your document and the menu should be ordered by what is the most logical flow when you want to learn about Property Editors.

Copy link
Contributor

@Luuk1983 Luuk1983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@leekelleher leekelleher self-requested a review December 15, 2025 09:19
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the updates from a technical perspective. Excellent work! πŸš€

Updated the README.md to improve clarity and consistency in the links and descriptions for Property Editors.
Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great @busrasengul πŸ‘

I've made a single comment - let me know what you think!

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more comments on too-long sentences.

@sofietoft sofietoft merged commit 81fd6a1 into umbraco:main Jan 5, 2026
48 of 50 checks passed
@busrasengul
Copy link
Contributor Author

Sorry @sofietoft been on holiday since the 15th.. Thank you for merging <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants