This repository was archived by the owner on Dec 13, 2021. It is now read-only.
Open
Conversation
mattbrailsford
suggested changes
Mar 18, 2019
mattbrailsford
left a comment
There was a problem hiding this comment.
Changes look good but a couple of extra things are needed:
- If we aren't using
localStorageServicethen there is no need for it to be injected as a dependency. - Need to update the canCopyContent / canPasteContent methods to check session storage is available rather than the local storage service (I dunno if it's possible that local storage is supported but session storage isn't, but either way, it should probably consistant)
I'm not as precious about the following idea, but thought it worth sharing (@leekelleher maybe you have some thoughts):
I wonder if creating our own storageService might be a more robust approach here. Internally this could use the umbraco localStorageService and check to see if sessionStorage is supported. If not, use our own implementation, but if it is, then use cores. This way it's kinda self upgrading and keeps all the storage code in a single location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.