Conversation
- Removed fallback behavior in config migration: default_file is now migrated to fortune_files as-is, without validating or rewriting paths. This preserves the original configuration intent and ensures deterministic behavior. - Introduced stable app_dir() override via OnceLock for test environments, preventing configuration and cache writes from affecting the user's system. - Updated loader and utils tests to use sandbox directories instead of system config locations. - Standardized canonical_key usage for cache read/write to ensure consistent no-repeat behavior across platforms (Linux / Windows / macOS). This resolves test failures on Windows and ensures consistent behavior during migration and cache operations.
…_dir() is unavailable - Improved app_dir() to handle cases where dirs::data_dir() returns None (e.g. CI environments) - Now falls back to $HOME/.local/share/rfortune on Linux and $HOME/Library/Application Support/rfortune on macOS - Guarantees consistent behavior across all platforms, including GitHub Actions runners - Added informational log message showing the active configuration directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves test failures on Windows and ensures consistent behavior during migration and cache operations.