Fix frontend not respecting ADMIN_EDIT config#2001
Merged
Conversation
Add admin_edit field to frontend Config types and use it in comment component to give admins unlimited edit time and allow editing comments with replies. Hide countdown timer when editDeadline is Infinity. Fixes #1986
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2001 +/- ##
==========================================
+ Coverage 64.88% 64.92% +0.03%
==========================================
Files 140 140
Lines 3258 3264 +6
Branches 815 827 +12
==========================================
+ Hits 2114 2119 +5
- Misses 1030 1031 +1
Partials 114 114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The backend correctly allows admins unlimited edit time when
ADMIN_EDIT=true, but the frontend doesn't use theadmin_editconfig value from/api/v1/config. This means the edit button disappears for admins after the normal edit window expires, even though the backend would accept the edit.Changes:
admin_edit: booleanto frontend Config types (app + API package)editDeadline = Infinityfor admin users whenadmin_editis enabledadmin_editis on)editDeadlineisInfinityFixes #1986