Skip to content

fix: false positive with no-rename-default #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix: false positive with no-rename-default #157

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3f1e896
update
Zamiell Sep 10, 2024
fa76200
update
Zamiell Sep 10, 2024
70fe36a
update
Zamiell Sep 10, 2024
2c8ac8f
update
Zamiell Sep 11, 2024
b2d29e0
update
Zamiell Sep 11, 2024
8fe2996
Merge branch 'master' into no-rename-default-fix
Zamiell Oct 5, 2025
c6d13c4
fix: equals
Zamiell Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/young-pants-warn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-plugin-import-x": patch
---

fix false positive for no-rename-default
11 changes: 11 additions & 0 deletions src/rules/no-rename-default.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,17 @@ export default createRule<[Options?], MessageId>({
return
}

// Some packages have a default export that is meant to be renamed. For example,
// "typescript-eslint" has a default export of "_default" and "eslint-plugin-jsdoc" has a
// default export of "index".
const defaultExportNameTrimmed = defaultExportName.replace(/^_+/, '') // Trim leading underscores.
if (
defaultExportNameTrimmed === 'default' ||
defaultExportNameTrimmed == 'index'
) {
return
}

const importTarget = node.parent.source?.value
const importBasename = path.basename(exportMap.path)

Expand Down
Loading