-
-
Notifications
You must be signed in to change notification settings - Fork 53
chore(deps): update dependency tmp to v0.2.4 [security] #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipped PR review on 972ead7 because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away.
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #416 +/- ##
=======================================
Coverage 96.10% 96.10%
=======================================
Files 96 96
Lines 4952 4952
Branches 1862 1860 -2
=======================================
Hits 4759 4759
Misses 192 192
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
972ead7
to
9fba4a4
Compare
This PR contains the following updates:
0.2.3
->0.2.4
GitHub Vulnerability Alerts
CVE-2025-54798
Summary
[email protected]
is vulnerable to an Arbitrary temporary file / directory write via symbolic linkdir
parameter.Details
According to the documentation there are some conditions that must be held:
Related issue: https://github.com/raszi/node-tmp/issues/207.
The issue occurs because
_resolvePath
does not properly handle symbolic link when resolving paths:If the
dir
parameter points to a symlink that resolves to a folder outside thetmpDir
, it's possible to bypass the_assertIsRelative
check used in_assertAndSanitizeOptions
:PoC
The following PoC demonstrates how writing a tmp file on a folder outside the
tmpDir
is possible.Tested on a Linux machine.
tmpDir
that points to a directory outside of it$HOME/mydir1
(outside thetmpDir
):main.js
A Potential fix could be to call
fs.realpathSync
(or similar) that resolves also symbolic links.Impact
Arbitrary temporary file / directory write via symlink
Release Notes
raszi/node-tmp (tmp)
v0.2.4
Compare Source
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.