refactor: first step toward ESLint 10 support

[SukkaW]

Fixes #452 and #455 , and a step toward #438.

• sourceType prefers context.languageOptions when possible
• The access to context.parserOptions by sourceType is now guarded, which fixes TypeError in @import/unambiguous crashes linter #452
• Merge getParser and getParserPath impl into one getParserOrPath

---

Important

Refactor for ESLint 10 support by updating sourceType preference and merging parser functions in parse.ts.

• Behavior:
  • sourceType in source-type.ts now prefers context.languageOptions over context.parserOptions.
  • Access to context.parserOptions in sourceType is now guarded to prevent errors.
• Functions:
  • Merges getParser and getParserPath into getParserOrPath in parse.ts.
• Misc:
  • Renames path to nodePath in parse.ts.

^{This description was created by for a58501c. You can customize this summary. It will automatically update as commits are pushed.}

Summary by CodeRabbit

• Chores

  • Preparation for ESLint 10 compatibility.

• Refactor

  • Improved parser selection logic to better support custom parsers and alternate configurations.
  • Enhanced source type resolution to prioritize modern configuration settings with backward compatibility fallbacks.

[changeset-bot]

🦋 Changeset detected

Latest commit: 932a8b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
eslint-plugin-import-x	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to a58501c in 6 seconds. Click for details.

• Reviewed 101 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 0 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_TVOcxA287xjliOKs

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[coderabbitai]

📝 Walkthrough

Walkthrough

A changeset is added for ESLint 10 support. Parser selection logic is refactored in parse.ts by introducing getParserOrPath to check custom parser configurations. SourceType resolution is refactored in source-type.ts to prioritize languageOptions with fallback handling, addressing an undefined reference crash.

Changes

Cohort / File(s)	Summary
Changeset .changeset/some-moments-trade.md	Added patch release note documenting first step toward ESLint 10 support.
Parser Utilities Refactoring src/utils/parse.ts, src/utils/source-type.ts	Renamed parser resolution function to getParserOrPath with updated logic to check context.settings['import-x/parsers'] for custom parsers with fallback chains. Refactored sourceType resolution to prioritize languageOptions with backward-compatible fallback to parserOptions when undefined.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• fix: pnp issue when used in a monorepo #390: Modifies parser selection logic in src/utils/parse.ts by updating how the chosen parser is passed to the resolver.

Suggested labels

refactor, bug

Poem

🐰 A parser's path now clearly shown,
With settings checked and fallbacks known,
SourceType finds its rightful place,
No more undefined in cyberspace!
ESLint ten, we're on our way,
With cleaner code each coding day! 🌟

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main objective—adding ESLint 10 support—and aligns with the PR's primary focus of refactoring sourceType resolution and parser handling for ESLint 10 compatibility.
Linked Issues check	✅ Passed	Changes directly address issue #452 by making sourceType access resilient to undefined parserOptions and refactoring parser utilities, preventing the TypeError that crashed the linter.
Out of Scope Changes check	✅ Passed	All modifications remain focused on ESLint 10 support: sourceType resolution updates, parser utility consolidation, and changeset entry—all aligned with stated PR objectives.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into master
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-import-x@454

commit: 932a8b5

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/utils/parse.ts (1)

188-196: ⚠️ Potential issue | 🔴 Critical

Bug: typeof parse references the module-level export, not parser.parse.

On line 191, typeof parse === 'function' resolves to the parse function exported at line 71 of this file — it's always true. The intended check is typeof parser.parse === 'function', consistent with the parseForESLint check on line 193.

This means any object with a parse property (regardless of type) passes validation, which could lead to a runtime error later if parser.parse isn't actually callable.

🐛 Proposed fix

   if (
     parser &&
     typeof parser !== 'string' &&
-    (('parse' in parser && typeof parse === 'function') ||
+    (('parse' in parser && typeof parser.parse === 'function') ||
       ('parseForESLint' in parser &&
         typeof parser.parseForESLint === 'function'))
   ) {

[Copilot]

Pull request overview

This PR takes the first step toward ESLint 10 support by refactoring how the plugin accesses parser configuration, specifically addressing a critical crash bug (#452) and preparing for the removal of context.parserPath in ESLint 10.

Changes:

• Fixed TypeError crash when context.parserOptions is undefined by adding proper existence guards and prioritizing languageOptions (flat config) over legacy parserOptions
• Consolidated getParser and getParserPath into a single getParserOrPath function with proper guards for context.parserPath access
• Renamed path import to nodePath to avoid naming conflicts with function parameters

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/utils/source-type.ts	Refactored to prioritize languageOptions over parserOptions with proper guards, fixing the crash from issue #452
src/utils/parse.ts	Merged parser resolution logic into getParserOrPath, added guards for context.parserPath, and renamed path import to avoid conflicts
.changeset/some-moments-trade.md	Added changeset documenting this as a patch release for ESLint 10 support

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	eslint@​8.56.0
	simple-git-hooks@​2.13.0
	jest@​30.0.3
	nano-staged@​0.8.0
	typescript-eslint@​8.35.0
	yarn-berry-deduplicate@​6.1.3
	premove@​4.0.0
	lodash@​4.17.21
	stable-hash-x@​0.2.0
	tmp@​0.2.5
	tinyexec@​1.0.1
	ts-node@​10.9.2
	klaw-sync@​7.0.0
	path-serializer@​0.5.0
	redux@​5.0.1
	npm-run-all2@​8.0.4
	@​eslint/​js@​8.56.0
	tsdown@​0.12.9
	unrs-resolver@​1.9.2
	prettier@​3.6.1
	minimatch@​10.0.1

View full report