feat: support for mutable data in apply() function #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage after merging api/apply into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for mutable data within the apply() function and updates related types/interfaces, along with a new test case to verify mutable behavior.
- Added a new test case in test/apply.test.ts to validate mutable operations.
- Updated the type definitions in src/interface.ts to include ApplyMutableOptions and adjusted ApplyOptions and ApplyResult types.
- Modified the apply() function in src/apply.ts to handle mutable patch application.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/apply.test.ts | Adds tests to validate both immutable and mutable patch apply. |
| src/interface.ts | Introduces ApplyMutableOptions and refines ApplyOptions types. |
| src/apply.ts | Updates apply() signature to support mutable operations and adjusts internal type usage. |
Comments suppressed due to low confidence (1)
src/apply.ts:52
- [nitpick] Since the mutate function now accepts both Draft and T, consider renaming the parameter (or adding an inline comment) to clarify that it can refer to either a draft or a plain state, which will aid future maintainers in understanding the intent.
const mutate = (draft: Draft<T> | T) => {
|
Coverage after merging api/apply into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#54