Facet position & displayName #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 18, 2017
unbxdSearch.js
Outdated
| if(type === "facet_ranges") | ||
| return options.fn(this); | ||
| else | ||
| return options.inverse(this); |
There was a problem hiding this comment.
Expected '{' and instead saw 'return'.
houndci-bot
reviewed
Jan 18, 2017
unbxdSearch.js
Outdated
| @@ -348,6 +348,13 @@ var unbxdSearchInit = function(jQuery, Handlebars){ | |||
| return txt.trim().length > 0 ? txt : " "; | |||
| }); | |||
|
|
|||
| Handlebars.registerHelper("isRangeFacet", function(type, options){ | |||
| if(type === "facet_ranges") | |||
| return options.fn(this); | |||
There was a problem hiding this comment.
Expected '{' and instead saw 'return'.
santosh1994
force-pushed
the
facet-positioning
branch
2 times, most recently
from
bd2ef60 to
b41e621
Compare
houndci-bot
reviewed
Jan 27, 2017
test/search/facetPosition.spec.js
Outdated
| isSorted = true; | ||
| //apply facet | ||
| facetElement.click(); | ||
| var sortedFacets = this.spyOnFacetTemp.args[0][0].sortedFacets; |
There was a problem hiding this comment.
'sortedFacets' is already defined.
houndci-bot
reviewed
Jan 27, 2017
test/search/facetPosition.spec.js
Outdated
| document.body.innerHTML = __html__['index.html']; | ||
|
|
||
| var searchConfig = jQuery.extend({}, window.config); | ||
| searchConfig.facetTemp = function(sortedFacets){}; |
There was a problem hiding this comment.
'sortedFacets' is defined but never used.
santosh1994
force-pushed
the
facet-positioning
branch
3 times, most recently
from
da95590 to
d5edc06
Compare
santosh1994
force-pushed
the
facet-positioning
branch
from
d5edc06 to
9bb7b20
Compare
|
@praveen612 Please review. we can add this express demo if required. /cc @anantheshadiga |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rahulcs @floydpraveen Please review
/cc @anantheshadiga