feat: support tracking stable branches#14
Conversation
Also we mark these structs as #[non_exhaustive] since more information may be introduced in the future.
There was a problem hiding this comment.
This looks good and seems to work! I appreciate your comments about the different changes you made in the PR comment - very helpful. We can leave the pagination parameters hack if you think it'll help perf, I doubt it would make it worse.
@acid-bong does this match your expectations for this behavior?
For what it's worth some very sketchy tests seem to put this PR at 33% and 47% faster for similar recently merged PRs (2.23s and 2.35s on main, vs 1.49s and 1.23s on this branch). Small sample but it does seem like a good idea! |
|
My internet is too slow today, not sure if i can test it (i really hope this comment gets sent) |
Now that's perfect, thx a lot |
|
Push a reformat commit, should pass CI now 😆 |
|
Sorry for the delay, I had some annoying issues with release-please and cargo/crates.io publishing. Gave up on most of it and published v0.5.0 locally which finally includes your changes here. Thanks so much! ❤️ |
Closes #13.
This PR implements tracking for stable branches. It includes the following changes:
headandbasefields of the API json responses, held in thePullRequeststruct. Adding these fields is technically a breaking change for the lib crate, but really no one should be constructing these responses by hand and the fields are clearly non-exhaustive, so we take the chance to add the#[non_exhaustive]marker to the relevant structs.