Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently in the plugins.properties some properties are written with capital letters like 'Theme' or 'RecentChanges'. And some are written with lowercase letters like 'test.history.days' or 'newpage.default.content'.
So wouldn't it make sense to have every property either in capital or lowercase letters? Since it seemed to me that there are more properties in capital letters I change the other ones.
I kept the logic for the old properties and added the new one on top if configured, so running systems won't break by this change.
It looks kinda wrong to have both properties in the code, but I am sure someone knows if this would make sense or not.