Skip to content

Feat: initial ci - #7

Merged
unclepomedev merged 4 commits into
mainfrom
feat/ci
Apr 29, 2026
Merged

Feat: initial ci#7
unclepomedev merged 4 commits into
mainfrom
feat/ci

Conversation

@unclepomedev

@unclepomedev unclepomedev commented Apr 29, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores

    • Added automated CI/CD pipeline for code quality checks and testing across frontend and backend.
    • Configured dependency management and update scheduling to maintain project dependencies.
  • Tests

    • Refactored test infrastructure and assertions for improved maintainability.

@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@unclepomedev has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 41 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9cd78910-534b-45d8-814c-38e4506f45c8

📥 Commits

Reviewing files that changed from the base of the PR and between dd08920 and 562ca21.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
📝 Walkthrough

Walkthrough

A new GitHub Actions CI workflow is added to run automated checks on pushes and pull requests, executing Rust and frontend linting, formatting, clippy, and tests. Additionally, a Renovate configuration enables automated dependency management with scheduled weekly updates and grouped package rules.

Changes

Cohort / File(s) Summary
CI/CD Infrastructure
.github/workflows/ci.yml, renovate.json
GitHub Actions workflow added for Rust (formatting, clippy, tests) and frontend (Biome) checks. Renovate config introduced with weekly update schedule, dependency grouping rules, and pins for GitHub Actions and major monorepos.
Test Refactoring
src-tauri/src/credentials.rs
Integration test helpers refactored: keychain entry creation and API key validation extracted into reusable keychain_entry_for and validate_api_key functions. Test assertions simplified from assert_eq! to assert!/assert! patterns.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 With workflows in place and dependencies keen,
The CI gates now run fresh and clean,
Tests refactored bright, helpers align,
Rabbits approve—automation divine!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title 'Feat: initial ci' clearly describes the main change—introduction of CI configuration files and workflows.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 51 minutes and 41 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@unclepomedev unclepomedev changed the title Feat/ci Feat: initial ci Apr 29, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)

45-67: Align Rust matrix targets with the project’s macOS-only scope.

Line 45 and Line 67 run clippy/tests on Linux and Windows too. For a macOS-only target, this can add non-target failures and unnecessary CI time; consider making macOS the required lane and others optional/experimental.

Based on learnings: In this repository’s Tauri Rust code, the app is intentionally macOS-only by design.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yml around lines 45 - 67, Update the CI job matrices so
both the Clippy job (the one containing the "Run Clippy" step) and the test job
(named "Test on ${{ matrix.os }}") only target macOS: replace the matrix.os
arrays that currently list ubuntu-latest, windows-latest, macos-latest with a
single entry macos-latest, and update any runs-on references or job name
templating accordingly (e.g., change "Test on ${{ matrix.os }}" to a fixed "Test
on macOS" or equivalent) so Clippy and tests run only on macOS while removing
Linux/Windows from the required lanes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/ci.yml:
- Line 17: The workflow is using a mutable tag for the Bun setup action ("uses:
oven-sh/setup-bun@v2"), which differs from other SHA-pinned actions; replace
that tag with the action's full commit SHA (e.g., "uses:
oven-sh/setup-bun@<commit-sha>") so the workflow is pinned to an immutable
commit; locate the line containing oven-sh/setup-bun@v2 and update it to the
corresponding full commit SHA from the oven-sh/setup-bun repository.

---

Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 45-67: Update the CI job matrices so both the Clippy job (the one
containing the "Run Clippy" step) and the test job (named "Test on ${{ matrix.os
}}") only target macOS: replace the matrix.os arrays that currently list
ubuntu-latest, windows-latest, macos-latest with a single entry macos-latest,
and update any runs-on references or job name templating accordingly (e.g.,
change "Test on ${{ matrix.os }}" to a fixed "Test on macOS" or equivalent) so
Clippy and tests run only on macOS while removing Linux/Windows from the
required lanes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c3cc0cfb-92e8-4891-9c12-715f413c7c89

📥 Commits

Reviewing files that changed from the base of the PR and between 9555a59 and dd08920.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • renovate.json
  • src-tauri/src/credentials.rs

Comment thread .github/workflows/ci.yml Outdated
The `clippy` and `test` jobs now run exclusively on `macos-latest`. This change
reduces CI execution time and focuses testing on the primary target platform.

Updates the `setup-bun` action to a specific commit hash for stability.
@unclepomedev
unclepomedev merged commit 270602a into main Apr 29, 2026
5 checks passed
@unclepomedev
unclepomedev deleted the feat/ci branch April 29, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant