Fix timing issues with file processing with multiple file sources #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Same as my 2 points in #228 (comment) You are creating a lot of noise. Just clone the repo and make sure your branch is green locally before pushing anything... Also, do not make unrelated changes. |
Author
Sorry, about that. I didn't have lint setup in the forked repository, I have fixed the issues now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #227
I have added a
fileInProcesscounter which is incremented before callinguncssand decremented on callback called.On this flag turns to zero, I am calling the
done()callback, as opposed to current code which is calling done on first file processed.